Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Chinese translations. #12699

Closed
wants to merge 1 commit into from
Closed

Conversation

shichangzhi
Copy link
Contributor

Explanation: Correct the translation of wrong words and sentences.

@shichangzhi shichangzhi requested a review from a team as a code owner November 14, 2021 09:35
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@wxy
Copy link

wxy commented Nov 14, 2021

Don't tinker with this translation anymore, I did a full update (PR #12694) , to keep up with the latest English I18N.

@shichangzhi
Copy link
Contributor Author

Don't tinker with this translation anymore, I did a full update (PR #12694) , to keep up with the latest English I18N.

I looked through your PR ( #12694 ) and it seems that your work may be causing some errors. Maybe it's better to take things one step at a time.
But your idea is very good. You can continue to perfect your translation, or I will try to retranslate the whole document when I'm done with what I'm doing.

@darkwing darkwing added the area-translation Issues relating to translating the app into various languages. label Nov 14, 2021
@mcmire
Copy link
Contributor

mcmire commented Jan 6, 2022

Hey, sorry it's taken us a while to get back to you. We have a lot of new translations coming in via #13206, so I'll wait until that's merged first.

@mcmire mcmire added the blocked label Jan 6, 2022
@kumavis kumavis removed the blocked label Jul 30, 2022
@brad-decker
Copy link
Contributor

@shichangzhi the new translation system has had a few iterations merged now, would you mind rebasing and checking your translations against the new ones to see if the changes are still applicable/necessary?

@wxy
Copy link

wxy commented Sep 16, 2022

@shichangzhi the new translation system has had a few iterations merged now, would you mind rebasing and checking your translations against the new ones to see if the changes are still applicable/necessary?

The new translation system? Where is it? I would like to take over the translation of Chinese.

@brad-decker
Copy link
Contributor

You may continue to make suggestions via pr, but its called crowdin and you can see the prs they open, its automated.

@brad-decker
Copy link
Contributor

@wxy bump. Did you want to see this landed? If not please close the PR. If you do want to see this land please do a rebase for me :)

@wxy
Copy link

wxy commented Oct 14, 2022

@wxy bump. Did you want to see this landed? If not please close the PR. If you do want to see this land please do a rebase for me :)

@brad-decker , I would be more than happy to pick it back up and provide a complete and timely translation if my PR could be reviewed and merged in a timely manner. As with this PR and my previous PR submission (#12694), no one has reviewed and merged it, or it has taken a long time, which is very discouraging.

@brad-decker
Copy link
Contributor

@wxy I know it can be frustrating, and my sincere apologies. I just got back from vacation and will commit to reviewing this PR if the changes are made. I'm going to assign myself to this PR as well and we can work together on getting it landed.

@brad-decker brad-decker self-assigned this Nov 4, 2022
@brad-decker
Copy link
Contributor

@wxy when you are ready to rebase and get this ready for review, please re-open and I will take a look as swiftly as possible. Thanks for your contribution

@brad-decker brad-decker closed this Dec 5, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-translation Issues relating to translating the app into various languages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants