-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Chinese translations. #12699
Update Chinese translations. #12699
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Don't tinker with this translation anymore, I did a full update (PR #12694) , to keep up with the latest English I18N. |
I looked through your PR ( #12694 ) and it seems that your work may be causing some errors. Maybe it's better to take things one step at a time. |
Hey, sorry it's taken us a while to get back to you. We have a lot of new translations coming in via #13206, so I'll wait until that's merged first. |
@shichangzhi the new translation system has had a few iterations merged now, would you mind rebasing and checking your translations against the new ones to see if the changes are still applicable/necessary? |
The new translation system? Where is it? I would like to take over the translation of Chinese. |
You may continue to make suggestions via pr, but its called crowdin and you can see the prs they open, its automated. |
@wxy bump. Did you want to see this landed? If not please close the PR. If you do want to see this land please do a rebase for me :) |
@brad-decker , I would be more than happy to pick it back up and provide a complete and timely translation if my PR could be reviewed and merged in a timely manner. As with this PR and my previous PR submission (#12694), no one has reviewed and merged it, or it has taken a long time, which is very discouraging. |
@wxy I know it can be frustrating, and my sincere apologies. I just got back from vacation and will commit to reviewing this PR if the changes are made. I'm going to assign myself to this PR as well and we can work together on getting it landed. |
@wxy when you are ready to rebase and get this ready for review, please re-open and I will take a look as swiftly as possible. Thanks for your contribution |
Explanation: Correct the translation of wrong words and sentences.