Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update eth_sign warning language #12034

Merged
merged 2 commits into from
Sep 8, 2021
Merged

Update eth_sign warning language #12034

merged 2 commits into from
Sep 8, 2021

Conversation

kumavis
Copy link
Member

@kumavis kumavis commented Sep 7, 2021

previous: #11337

@kumavis kumavis requested a review from a team as a code owner September 7, 2021 22:46
@kumavis kumavis requested a review from ryanml September 7, 2021 22:46
@kumavis kumavis mentioned this pull request Sep 7, 2021
Merged
ryanml
ryanml approved these changes Sep 7, 2021
View reviewed changes
Copy link
Contributor

@ryanml ryanml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@metamaskbot
Copy link
Collaborator

Builds ready [9bb4ad3]
Page Load Metrics (627 ± 80 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint112877475262126
domContentLoaded38487761616780
load39789362716680
domInteractive38487661616780

@kumavis kumavis merged commit 5daf8cc into develop Sep 8, 2021
@kumavis kumavis deleted the kumavis-patch-2 branch September 8, 2021 02:10
@github-actions github-actions bot locked and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vickcharles vickcharles vickcharles approved these changes

@ryanml ryanml ryanml approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kumavis @metamaskbot @ryanml @vickcharles