Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving warning text for eth_sign #12013

Merged
merged 2 commits into from
Sep 6, 2021
Merged

Improving warning text for eth_sign #12013

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1461bb2
Improving warning text for eth_sign
ryanml Sep 3, 2021
b755afb
Copy update
ryanml Sep 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/_locales/en/messages.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1958,7 +1958,7 @@
"message": "Sign"
},
"signNotice": {
"message": "Signing this message can have \ndangerous side effects. Only sign messages from \nsites you fully trust with your entire account.\n This dangerous method will be removed in a future version. "
"message": "We are unable to estimate the result of this signature. This signature could potentially perform any operation on your account's behalf, including granting complete control of your account and all of its assets to the requesting site. Only sign this message if you know what you're doing or completely trust the requesting site."
Copy link
Contributor

@adonesky1 adonesky1 Sep 3, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor proposed change to copy : "We are unable to predict the result of this signature..."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

},
"signatureRequest": {
"message": "Signature Request"
Expand Down
2 changes: 2 additions & 0 deletions ui/components/app/signature-request-original/index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,7 @@

&__notice {
color: $dusty-gray;
padding: 0 10px;
}

&__warning {
Expand Down Expand Up @@ -228,6 +229,7 @@
cursor: pointer;
text-decoration: underline;
color: $primary-blue;
margin-inline-start: 3px;
}

&__footer {
Expand Down