-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added getPersistentState
support for V2 controllers persist
metadata
#12007
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [000d1c5]
Page Load Metrics (509 ± 47 ms)
|
Builds ready [000d1c5]
Page Load Metrics (509 ± 47 ms)
|
I've scanned through all of our BaseControllerV2-based controllers to get a sense of what the impact of this will be.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
This PR adds
getPersistentState
support for BaseController V2 to provide persist metadata to localstorage of the extension