Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using a normal bundle instead of a factored bundle for phishing-detect (build-sys) #11972

Merged
merged 1 commit into from
Aug 31, 2021

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Aug 30, 2021

Fixes: #11971 - since this was previously a factored build, phishing.html was not referencing the correct bundled js file: https://github.com/MetaMask/metamask-extension/blob/develop/app/phishing.html#L8 - this should be fine as a normal bundle

@ryanml ryanml requested a review from kumavis August 30, 2021 21:45
@ryanml ryanml requested a review from a team as a code owner August 30, 2021 21:45
@ryanml ryanml self-assigned this Aug 30, 2021
@ryanml ryanml requested a review from PeterYinusa August 30, 2021 21:45
kumavis
kumavis previously approved these changes Aug 30, 2021
@kumavis
Copy link
Member

kumavis commented Aug 30, 2021

Error: SourcemapValidator - failed to load source file for "phishing-detect-0.js"

sourcemap validator needs to be updated

@ryanml
Copy link
Contributor Author

ryanml commented Aug 30, 2021

@kumavis - validator updated 👍

@ryanml ryanml requested a review from kumavis August 30, 2021 23:19
@metamaskbot
Copy link
Collaborator

Builds ready [1a7f87c]
Page Load Metrics (622 ± 14 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint51846694
domContentLoaded5216606202914
load5236616222914
domInteractive5216606202914

@ryanml ryanml force-pushed the phishing-forwarding-fix branch from 1a7f87c to ca7f58a Compare August 31, 2021 00:00
rekmarks
rekmarks previously approved these changes Aug 31, 2021
Copy link
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@metamaskbot
Copy link
Collaborator

Builds ready [ca7f58a]
Page Load Metrics (634 ± 15 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint53846274
domContentLoaded5957096333115
load5977106343115
domInteractive5957096333115

@kumavis
Copy link
Member

kumavis commented Aug 31, 2021

we should still validate it

@ryanml ryanml force-pushed the phishing-forwarding-fix branch from 6be0952 to aeccbb5 Compare August 31, 2021 00:26
@ryanml ryanml requested a review from rekmarks August 31, 2021 00:29
@metamaskbot
Copy link
Collaborator

Builds ready [aeccbb5]
Page Load Metrics (636 ± 14 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint51846573
domContentLoaded5897016353014
load5917026363014
domInteractive5897006343014

@kumavis kumavis merged commit 4b4303c into develop Aug 31, 2021
@kumavis kumavis deleted the phishing-forwarding-fix branch August 31, 2021 03:58
@github-actions github-actions bot locked and limited conversation to collaborators Aug 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Continue at your own risk" button does not work
4 participants