Ensure that eth_estimateGas is called to estimate gas limit for simple sends on custom networks #11418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
…e sends on custom networks
danjm
force-pushed
the
custom-networks-gas-limits
branch
from
cce7d84 to
972a46a
Compare
brad-decker
previously approved these changes
Jun 29, 2021
ui/selectors/selectors.js
Outdated
| @@ -376,6 +376,10 @@ export function getIsTestnet(state) { | |||
| return TEST_CHAINS.includes(chainId); | |||
| } | |||
|
|
|||
| export function getIsNonStandardEthChain(state) { | |||
| return !(getIsMainnet(state) || getIsTestnet(state)); | |||
There was a problem hiding this comment.
you should probably return false if IN_TEST to match some of our other logic to treat ganache as mainnet in tests.
Builds ready [5fafef1]
Page Load Metrics (523 ± 53 ms)
|
brad-decker
previously approved these changes
Jun 29, 2021
adonesky1
reviewed
Jun 30, 2021
| ); | ||
| } | ||
|
|
||
| const bufferMultiplier = isSimpleSendOnNonStandardNetwork ? 1 : 1.5; |
There was a problem hiding this comment.
Would it be possible to add a comment explaining the variance in the bufferMultiplier?
There was a problem hiding this comment.
@adonesky1 added in the latest commit
adonesky1
approved these changes
Jun 30, 2021
Builds ready [be48eda]
Page Load Metrics (680 ± 57 ms)
|
brad-decker
approved these changes
Jun 30, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates our gas estimation logic so that if we are doing a simple send on a network that is not one of the default/standard networks in metamask (e.g. eth mainnet, or the test networks supported by infura), then we set the gas estimate to the result of calling
eth_gasEstimateThis will enable custom networks to set gas prices for simple sends that are different than
21000