Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor add/hide token tests to use fixture #11183

Merged
merged 2 commits into from
May 26, 2021
Merged

refactor add/hide token tests to use fixture #11183

merged 2 commits into from
May 26, 2021

Conversation

PeterYinusa
Copy link
Contributor

@PeterYinusa PeterYinusa commented May 25, 2021 •
edited
Loading

Related: #11136

Explanation:

  • moved hide token and add existing token tests
  • updated tests to use fixtures

@PeterYinusa PeterYinusa requested a review from a team as a code owner May 25, 2021 22:05
@metamaskbot
Copy link
Collaborator

Builds ready [387b137]
Page Load Metrics (707 ± 64 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint459968136
domContentLoaded43092870513464
load43293070713464
domInteractive43092870513464

NiranjanaBinoy
NiranjanaBinoy approved these changes May 26, 2021
View reviewed changes
Copy link
Contributor

@NiranjanaBinoy NiranjanaBinoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PeterYinusa PeterYinusa merged commit 3b68fc4 into develop May 26, 2021
@PeterYinusa PeterYinusa deleted the e2e-fixtures-add-hide-token branch May 26, 2021 20:36
ryanml pushed a commit that referenced this pull request Jun 22, 2021
@PeterYinusa @ryanml
refactor add/hide token tests to use fixture (#11183)
3878d1b 
* refactor add/hide token tests to use fixture

* refactor add/hide token tests to use fixture
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NiranjanaBinoy NiranjanaBinoy NiranjanaBinoy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PeterYinusa @metamaskbot @NiranjanaBinoy