implement safer to buffer

[brad-decker]

Fixes another sentry issue that has surfaced related to ethereumjs-util upgrade. This time the toBuffer method from ethereumjs-util is the issue. I have made a new buffer-utils file in shared/modules that is safe to use even with non hex prefixed strings, but I don't know that we always want to allow for that kind of input. There are two cases where I haven't replaced using toBuffer with this method, which are in the transaction controller and account import code. I feel like we'd want an error thrown in these cases if ever a non prefixed hex string is returned from either signing a transaction or importing an account.

[Gudahtt]

There are two cases where I haven't replaced using toBuffer with this method, which are in the transaction controller and account import code. I feel like we'd want an error thrown in these cases if ever a non prefixed hex string is returned from either signing a transaction or importing an account.

Agreed - seems safer to leave those as-is for now.

[metamaskbot]

Builds ready [0494a5d]

• builds: chrome, firefox, opera
• bundle viz: background, ui, inpage, contentscript, ui-libs, bg-libs, phishing-detect
• build viz: Build System
• code coverage: Report
• storybook: Storybook
• all artifacts

Page Load Metrics (590 ± 34 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	45	83	62	11	5
		domContentLoaded	411	686	588	71	34
		load	413	687	590	71	34
		domInteractive	411	686	588	71	34

[Gudahtt]

LGTM!