Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve send slice tests #11091

Merged
merged 4 commits into from
May 25, 2021
Merged

Improve send slice tests #11091

merged 4 commits into from
May 25, 2021

Conversation

tmashuang
Copy link
Contributor

@tmashuang tmashuang commented May 13, 2021 •
edited
Loading

Most of the changes are adjustments to the tests as the state has slightly changed in #10965.

I have commented on certain lines that may, or may not, have been intended changes to discuss.

ui/ducks/gas/gas-duck.test.js
ui/ducks/send/send.test.js
are still WIP.

@tmashuang tmashuang requested a review from a team as a code owner May 13, 2021 23:36
@tmashuang tmashuang requested review from darkwing and removed request for a team May 13, 2021 23:36
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@tmashuang tmashuang marked this pull request as draft May 13, 2021 23:37
@tmashuang tmashuang changed the title Improve send slice tests [WIP] Improve send slice tests May 13, 2021
@brad-decker
Copy link
Contributor

You're my new favorite person. 😍❤️❤️

@brad-decker brad-decker force-pushed the improve-send-slice branch 2 times, most recently from 60a4eee to bd83c61 Compare May 18, 2021 22:36
@brad-decker brad-decker force-pushed the improve-send-slice branch from a3404c4 to 796904e Compare May 21, 2021 17:03
@tmashuang tmashuang force-pushed the improve-send-slice-tests branch from 5a4900f to e961851 Compare May 25, 2021 06:09
@tmashuang tmashuang changed the title [WIP] Improve send slice tests Improve send slice tests May 25, 2021
@tmashuang tmashuang marked this pull request as ready for review May 25, 2021 06:09
tmashuang
tmashuang commented May 25, 2021
View reviewed changes
ui/ducks/send/send.js Outdated Show resolved Hide resolved
tmashuang
tmashuang commented May 25, 2021
View reviewed changes
ui/ducks/send/send.test.js Outdated Show resolved Hide resolved
tmashuang
tmashuang commented May 25, 2021
View reviewed changes
ui/ducks/send/send.test.js Outdated Show resolved Hide resolved
tmashuang
tmashuang commented May 25, 2021
View reviewed changes
ui/selectors/custom-gas.js Outdated Show resolved Hide resolved
@metamaskbot
Copy link
Collaborator

Builds ready [f4e7974]
Page Load Metrics (626 ± 40 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint46736184
domContentLoaded3538296258340
load3558316268340
domInteractive3538296258340

@brad-decker
Copy link
Contributor

This is mergeable even with the test deps failing cause I can rebase the base branch after its included. You rock @tmashuang

@metamaskbot
Copy link
Collaborator

Builds ready [19e718f]
Page Load Metrics (627 ± 57 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint49776384
domContentLoaded37982562611857
load38082762711857
domInteractive37982562611857

@metamaskbot
Copy link
Collaborator

Builds ready [733987a]
Page Load Metrics (547 ± 43 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint46826194
domContentLoaded3776515468943
load3796525478943
domInteractive3776505458943

@brad-decker
Copy link
Contributor

LGTM, thanks again @tmashuang

@tmashuang tmashuang merged this pull request into improve-send-slice May 25, 2021
@tmashuang tmashuang deleted the improve-send-slice-tests branch May 25, 2021 18:24
brad-decker pushed a commit that referenced this pull request May 25, 2021
@tmashuang @brad-decker
Improve send slice tests (#11091)
5d00b10 
* Improve send slice tests
brad-decker pushed a commit that referenced this pull request Jun 7, 2021
@tmashuang @brad-decker
Improve send slice tests (#11091)
fbf0c6e 
* Improve send slice tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brad-decker brad-decker brad-decker approved these changes

@darkwing darkwing Awaiting requested review from darkwing

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tmashuang @brad-decker @metamaskbot