-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update swaps failure copy to help users get support #10525
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
2588cfe
to
b780a19
Compare
Builds ready [b780a19]
Page Load Metrics (565 ± 25 ms)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The non-English versions of this string do not accept substitutions, so this will blow Sentry up with errors.
Since you're making a substantial change to the message here, I think it should be renamed rather than edited.
b780a19
to
92cc850
Compare
@Gudahtt This has been updated according to your comment. |
92cc850
to
cc505cb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Builds ready [cc505cb]
Page Load Metrics (563 ± 37 ms)
|
Requested by product+design
After:
https://user-images.githubusercontent.com/7499938/109230492-8cc29580-779f-11eb-9ab3-05ac424b2e76.mp4