Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update swaps failure copy to help users get support #10525

Merged
merged 1 commit into from
Mar 1, 2021

Conversation

danjm
Copy link
Contributor

@danjm danjm commented Feb 25, 2021

@danjm danjm requested a review from a team as a code owner February 25, 2021 22:58
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@danjm danjm force-pushed the update-swap-failure-copy branch from 2588cfe to b780a19 Compare February 25, 2021 23:45
@metamaskbot
Copy link
Collaborator

Builds ready [b780a19]
Page Load Metrics (565 ± 25 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint47795784
domContentLoaded3626235635125
load3646255655125
domInteractive3626235635125

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The non-English versions of this string do not accept substitutions, so this will blow Sentry up with errors.

Since you're making a substantial change to the message here, I think it should be renamed rather than edited.

@danjm danjm force-pushed the update-swap-failure-copy branch from b780a19 to 92cc850 Compare March 1, 2021 15:51
@danjm
Copy link
Contributor Author

danjm commented Mar 1, 2021

@Gudahtt This has been updated according to your comment.

@danjm danjm force-pushed the update-swap-failure-copy branch from 92cc850 to cc505cb Compare March 1, 2021 15:59
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@metamaskbot
Copy link
Collaborator

Builds ready [cc505cb]
Page Load Metrics (563 ± 37 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint44725584
domContentLoaded3386575607837
load3406585637837
domInteractive3386575607837

@danjm danjm merged commit 46ecf70 into develop Mar 1, 2021
@danjm danjm deleted the update-swap-failure-copy branch March 1, 2021 16:32
@github-actions github-actions bot locked and limited conversation to collaborators Mar 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants