Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use chain id for enabling ENS IPFS resolution #10507

Merged
merged 2 commits into from
Feb 25, 2021
Merged

use chain id for enabling ENS IPFS resolution #10507

merged 2 commits into from
Feb 25, 2021

Conversation

brad-decker
Copy link
Contributor

Progresses: #8668
use chainId instead of network for enabling ENS IPFS resolution

screenshot

@brad-decker brad-decker force-pushed the ens-resolution-chain-id branch from 4a163ea to cf6f617 Compare February 23, 2021 20:57
@brad-decker brad-decker force-pushed the ens-resolution-chain-id branch from cf6f617 to 2d99795 Compare February 23, 2021 21:10
@metamaskbot
Copy link
Collaborator

Builds ready [2d99795]
Page Load Metrics (617 ± 32 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint46766184
domContentLoaded5287506166732
load5307516176732
domInteractive5287506156732

@brad-decker brad-decker marked this pull request as ready for review February 23, 2021 21:28
@brad-decker brad-decker requested a review from a team as a code owner February 23, 2021 21:28
@brad-decker brad-decker requested a review from Gudahtt February 23, 2021 21:28
Gudahtt
Gudahtt approved these changes Feb 25, 2021
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brad-decker brad-decker merged commit 15d78b8 into develop Feb 25, 2021
@brad-decker brad-decker deleted the ens-resolution-chain-id branch February 25, 2021 11:40
@github-actions github-actions bot locked and limited conversation to collaborators Feb 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brad-decker @metamaskbot @Gudahtt