Ensure that swap approve tx and swap tx always have the same gas price #10501
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug whereby the approve tx and swap tx created within our swaps feature could each have a different gas price. This would happen in the case when there is no custom gas price set, and the call to the swaps
/gasPrices
api fails. In such a case, both would get their gas price from theeth_gasPrice
method, but at different times (swap tx at the time quotes are requested, and approve tx at the time the swap is submitted).This PR fixes that by having both gas prices set by calling the same selector
getUsedSwapsGasPrice