Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes gas selection check mark on the notification view #10465

Merged
merged 1 commit into from
Feb 16, 2021
Merged

Fixes gas selection check mark on the notification view #10465

merged 1 commit into from
Feb 16, 2021

Conversation

tmashuang
Copy link
Contributor

Fixes: #10463

Before
After

@tmashuang tmashuang requested a review from a team as a code owner February 16, 2021 22:56
@tmashuang tmashuang requested a review from shanejonas February 16, 2021 22:56
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Gudahtt
Gudahtt approved these changes Feb 16, 2021
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@metamaskbot
Copy link
Collaborator

Builds ready [1e58c0f]
Page Load Metrics (549 ± 23 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint44735794
domContentLoaded3526015484823
load3536025494823
domInteractive3526015474823

@tmashuang tmashuang merged commit 1f79250 into develop Feb 16, 2021
@tmashuang tmashuang deleted the fix-notification-gas-check branch February 16, 2021 23:09
@github-actions github-actions bot locked and limited conversation to collaborators Feb 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

@shanejonas shanejonas Awaiting requested review from shanejonas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Font not showing the select under Customize Gas section
3 participants
@tmashuang @metamaskbot @Gudahtt