-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated es and es-419 translations #10258
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [6f62fc6]
Page Load Metrics (531 ± 31 ms)
|
If any community contributors would like to help review this PR, it would be greatly appreciated! I'll tag anyone here that has contributed in the past: @Pedro-vk @mapachurro @jonathansmirnoff @raulk @vimalsagar @hermanjunge @omartinex I wanted to give you all the opportunity to provide feedback because we owe our current translations to you. Please don't feel obliged if you don't have the time to review, and please let me know if you'd like me to stop tagging you for reviews in the future. Thanks! |
6f62fc6
to
54e8949
Compare
This PR has been rebased onto |
Builds ready [54e8949]
Page Load Metrics (545 ± 35 ms)
|
"activityLog": { | ||
"message": "registro de actividades" | ||
}, | ||
"addAccount": { | ||
"message": "Agregar una cuenta" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe I would use more "Añadir una cuenta". need confirmation by 1 more person to see if is worth changing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think "Agregar" makes sense here? At least if this comment is accurate: https://www.reddit.com/r/duolingo/comments/1alunr/what_is_the_difference_between_a%C3%B1adir_and_agregar/c8ylfwv/
The "Add" in this case is more the "add to a group/aggregate" case I think. Each account is independent.
"description": "$1 is the number of accounts to which the web3 site/application is asking to connect; this will substitute $1 in connectToMultiple" | ||
}, | ||
"connectWithMetaMask": { | ||
"message": "Conectar Con MetaMask" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Conectar con MetaMask"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, however, the english version is "Connect With Metamask".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems strange but if that is that is how we are using with the brand, then ok.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Connect With Metamask" means the dapp can read your ethereum address
The message `swapGetQuotes` is no longer used, so it has been removed. Additionally two descriptions were updated to be English. The descriptions are not meant to be translated.
54e8949
to
a26cb0a
Compare
I've rebased this PR and made a couple of minor lint fixes. @ricardolyn Thanks so much for the review! Just wondering - did you finish reviewing the |
Builds ready [a26cb0a]
Page Load Metrics (510 ± 43 ms)
|
yes, I finished. np 👍 |
Explanation: Updated es and es-419 translations.
Manual testing steps: Just change to Spanish or Spanish (Latin America) language configuration setting.
(This PR was originally created by @fernandospr in #10073, which was accidentally closed)