Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated es and es-419 translations #10258

Merged
merged 5 commits into from
Feb 16, 2021
Merged

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Jan 23, 2021

Explanation: Updated es and es-419 translations.

Manual testing steps: Just change to Spanish or Spanish (Latin America) language configuration setting.

(This PR was originally created by @fernandospr in #10073, which was accidentally closed)

@Gudahtt Gudahtt requested a review from a team as a code owner January 23, 2021 00:23
@Gudahtt Gudahtt requested a review from rekmarks January 23, 2021 00:23
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [6f62fc6]
Page Load Metrics (531 ± 31 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint41714984
domContentLoaded3455905306531
load3475915316531
domInteractive3455905306531

@Gudahtt
Copy link
Member Author

Gudahtt commented Jan 25, 2021

If any community contributors would like to help review this PR, it would be greatly appreciated!

I'll tag anyone here that has contributed in the past: @Pedro-vk @mapachurro @jonathansmirnoff @raulk @vimalsagar @hermanjunge @omartinex

I wanted to give you all the opportunity to provide feedback because we owe our current translations to you. Please don't feel obliged if you don't have the time to review, and please let me know if you'd like me to stop tagging you for reviews in the future.

Thanks!

@Gudahtt Gudahtt force-pushed the update-es-es419-translations branch from 6f62fc6 to 54e8949 Compare February 2, 2021 14:45
@Gudahtt
Copy link
Member Author

Gudahtt commented Feb 2, 2021

This PR has been rebased onto develop to ensure that the yourSigRequested message was not present (it was removed in #10300).

@metamaskbot
Copy link
Collaborator

Builds ready [54e8949]
Page Load Metrics (545 ± 35 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint44805694
domContentLoaded3336205437235
load3346215457235
domInteractive3336205437235

"activityLog": {
"message": "registro de actividades"
},
"addAccount": {
"message": "Agregar una cuenta"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I would use more "Añadir una cuenta". need confirmation by 1 more person to see if is worth changing

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "Agregar" makes sense here? At least if this comment is accurate: https://www.reddit.com/r/duolingo/comments/1alunr/what_is_the_difference_between_a%C3%B1adir_and_agregar/c8ylfwv/
The "Add" in this case is more the "add to a group/aggregate" case I think. Each account is independent.

"description": "$1 is the number of accounts to which the web3 site/application is asking to connect; this will substitute $1 in connectToMultiple"
},
"connectWithMetaMask": {
"message": "Conectar Con MetaMask"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Conectar con MetaMask"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, however, the english version is "Connect With Metamask".

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems strange but if that is that is how we are using with the brand, then ok.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Connect With Metamask" means the dapp can read your ethereum address

app/_locales/es/messages.json Show resolved Hide resolved
fernandospr and others added 5 commits February 15, 2021 18:08
The message `swapGetQuotes` is no longer used, so it has been removed.
Additionally two descriptions were updated to be English. The
descriptions are not meant to be translated.
@Gudahtt Gudahtt force-pushed the update-es-es419-translations branch from 54e8949 to a26cb0a Compare February 15, 2021 21:40
@Gudahtt
Copy link
Member Author

Gudahtt commented Feb 15, 2021

I've rebased this PR and made a couple of minor lint fixes.

@ricardolyn Thanks so much for the review! Just wondering - did you finish reviewing the es translations? Did you review es-419 as well?

@metamaskbot
Copy link
Collaborator

Builds ready [a26cb0a]
Page Load Metrics (510 ± 43 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint43845894
domContentLoaded3165935089043
load3185945108943
domInteractive3165935089043

@ricardolyn
Copy link

yes, I finished. np 👍

@Gudahtt Gudahtt merged commit b33a3de into develop Feb 16, 2021
@Gudahtt Gudahtt deleted the update-es-es419-translations branch February 16, 2021 12:26
@github-actions github-actions bot locked and limited conversation to collaborators Feb 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants