Remove default to 18 decimals in quotesToRenderableData method #10212
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where tokens with
0
decimals would show incorrect amounts on the view token screen.The default to 18 decimals was unnecessary, as we validate
/tokens
api responses inswaps.util.js
to verify that decimals are defined and either a number or a string of decimal digits between 0 and 36. If the decimals were somehow undefined by the time quotesToRenderableData inview-quote.js
, then it would be better that a user hit an error than be shown an incorrect default.A future improvement will be to add data validation to the
quotesToRenderableData
method