Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[email protected] #10169

Merged
merged 1 commit into from
Jan 11, 2021
Merged

[email protected] #10169

merged 1 commit into from
Jan 11, 2021

Conversation

rekmarks
Copy link
Member

  • [email protected]
    • Not breaking for our purposes.
    • Now supports method signatures with array arguments.

@rekmarks rekmarks requested a review from a team as a code owner January 10, 2021 19:56
@rekmarks rekmarks requested a review from Gudahtt January 10, 2021 19:56
@metamaskbot
Copy link
Collaborator

Builds ready [14b4adb]
Page Load Metrics (860 ± 142 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaintNaNNaNNaNNaNNaN
domContentLoaded4401456856291140
load4411472860295142
domInteractive4401455856291140

Gudahtt
Gudahtt approved these changes Jan 11, 2021
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rekmarks rekmarks merged commit d7c648d into develop Jan 11, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jan 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rekmarks @metamaskbot @Gudahtt