Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent malformed next nonce warning #10143

Merged
merged 1 commit into from
Jan 5, 2021

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Jan 5, 2021

The "Next nonce" warning warns users when the custom nonce they set is higher than our suggested nonce. This warning was mistakenly being shown even when we didn't have a suggested nonce yet.

Fixes #9989

The "Next nonce" warning warns users when the custom nonce they set is
higher than our suggested nonce. This warning was mistakenly being
shown even when we didn't have a suggested nonce yet.

Fixes #9989
@Gudahtt Gudahtt requested a review from a team as a code owner January 5, 2021 17:20
@Gudahtt Gudahtt requested a review from brad-decker January 5, 2021 17:20
@brad-decker
Copy link
Contributor

LGTM

@metamaskbot
Copy link
Collaborator

Builds ready [80ef866]
Page Load Metrics (806 ± 44 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaintNaNNaNNaNNaNNaN
domContentLoaded5739988049244
load5749998069244
domInteractive5729978049244

@Gudahtt Gudahtt merged commit 6f18989 into develop Jan 5, 2021
@Gudahtt Gudahtt deleted the prevent-malformed-next-nonce-warning branch January 5, 2021 17:46
@github-actions github-actions bot locked and limited conversation to collaborators Jan 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

customize transaction nonce missing in UI
3 participants