User can accept txs with insufficient funds and sometimes no callback

[danfinlay]

Apparently we sometimes do not call back an error when a user tries to accept a tx they do not have sufficient funds to complete.

Could be solved by #519

[frankiebee]

Half of this is fixed, but the other half would be solved by giving access to the account balanced while the account is locked and throwing an error before showing confirmation screen.

[frankiebee]

We want to throw an error if the user does not have enough funds..? Well at the moment you cant approve a transaction at all if the transaction is more then the balance so is the prposed flow be that it doesn't even show the confirmation screen and just shows an error screen?

[danfinlay]

This feature has been requested, I think it makes sense, but we don’t have access to balances when locked until after the multivault refactor.

On Oct 11, 2016, at 1:52 PM, Frankie [email protected] wrote:

We want to throw an error if the user does not have enough funds..? Well at the moment you cant approve a transaction at all if the transaction is more then the balance so is the prposed flow be that it doesn't even show the confirmation screen and just shows an error screen?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub #660 (comment), or mute the thread https://github.com/notifications/unsubscribe-auth/AAhIj2Yp_f-j1cnxT5iZh979MOyrrK9zks5qy_cRgaJpZM4J9BRc.

[frankiebee]

This is blocked by issue #328

[danfinlay]

We could start doing this on the dev branch now. Probably want to wait for it to be merged into master first.

[danfinlay]

Closing this because we're leaning towards a log-in-per-site, as suggested in #799.