Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrectly showing checksums on non-ETH blockchains #5838

Closed
herrerameri opened this issue Nov 26, 2018 · 1 comment
Closed

Incorrectly showing checksums on non-ETH blockchains #5838

herrerameri opened this issue Nov 26, 2018 · 1 comment
Labels
type-enhancement

Comments

@herrerameri
Copy link

herrerameri commented Nov 26, 2018 •
edited
Loading

Describe the bug
If you add a custom RPC node, the addresses are always shown as they're ETH addresses.

To Reproduce

  1. Add a CUSTOM RPC node (e.g.: RSK public node https://public-node.testnet.rsk.co)
  2. Look at default address: checksum is not correct for RSK, because it's ETH checksum

Expected behavior
If network chainId is not an ETH one, it's better to see the address without checksum (lower case) instead of an address with a checksum which is not correct.

Browser details (please complete the following information):

  • OS: Ubuntu - Linux
  • Browser Chrome
  • MetaMask 5.0.3
@bdresser bdresser changed the title Checksummed addresses Incorrectly showing checksums on non-ETH blockchains Nov 27, 2018
@aeidelman
Copy link

The ideal scenario would be to adopt EIP-1191. If not possible, showing non-checksumed addresses in these cases is better than current situation.

This was referenced Dec 21, 2018
Closed
Closed
@jonathansmirnoff jonathansmirnoff mentioned this issue Jan 7, 2019
Merged
jonathansmirnoff added a commit to jonathansmirnoff/metamask-extension that referenced this issue Jan 15, 2019
@jonathansmirnoff
Fixed issue MetaMask#5838
8c06e57
jonathansmirnoff added a commit to jonathansmirnoff/metamask-extension that referenced this issue Feb 5, 2019
@jonathansmirnoff
Fixed issue MetaMask#5838
6645a17 
Update changelog file
frankiebee pushed a commit that referenced this issue Feb 13, 2019
@jonathansmirnoff @frankiebee
Fixed issue #5838 (#6001)
8dddf48 
Update changelog file
@davidmurdoch davidmurdoch mentioned this issue Mar 6, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bdresser @aeidelman @herrerameri