Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to tab through unapproved txs #5330

Closed
whymarrh opened this issue Sep 24, 2018 · 5 comments
Closed

Add ability to tab through unapproved txs #5330

whymarrh opened this issue Sep 24, 2018 · 5 comments
Labels
area-UI Relating to the user interface.

Comments

@whymarrh
Copy link
Contributor

When a long list of unapproved transactions have built up, there should be some way to tab through all of them.

@whymarrh whymarrh added the area-UI Relating to the user interface. label Sep 24, 2018
@whymarrh whymarrh self-assigned this Sep 24, 2018
@bdresser
Copy link
Contributor

@whymarrh I think it'd make sense to have a visual indicator as well for non-pro uses. Check out #3425, where we're adding a small "1 of 3" indicator.

If we let the user flip through the transactions themselves, won't we increase the likelihood of nonce issues? Say, if the user tries to approve the third tx before the first?

@whymarrh
Copy link
Contributor Author

If we let the user flip through the transactions themselves, won't we increase the likelihood of nonce issues? Say, if the user tries to approve the third tx before the first?

The nonce for a new transaction is calculated when the user confirms it so we shouldn't have issues from what I understand.

@whymarrh
Copy link
Contributor Author

I'll un-assign myself from this for now until the work started in #3425 is complete

@whymarrh whymarrh removed their assignment Sep 24, 2018
@bdresser
Copy link
Contributor

design issue at MetaMask/Design#30

@tmashuang
Copy link
Contributor

Closing due to inactivity, all other related issues seem to be closed. Multiple transactions and batch transactions have been implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-UI Relating to the user interface.
Projects
None yet
Development

No branches or pull requests

3 participants