Skip to content
This repository has been archived by the owner on May 12, 2022. It is now read-only.

Moving between transactions in the confirm screen #30

Closed
alextsg opened this issue Jun 18, 2018 · 4 comments
Closed

Moving between transactions in the confirm screen #30

alextsg opened this issue Jun 18, 2018 · 4 comments

Comments

@alextsg
Copy link

alextsg commented Jun 18, 2018

In the old UI, users were able to move between transactions when confirming:
image
In the new UI, we currently render the oldest transaction and the user has to confirm/reject transactions in order. Should we implement the same UX in the new UI?

@bdresser
Copy link

So right now when you prompt a transaction, you can either confirm it in the standalone popup window, or in the popup attached to the extension bar. The behavior for stacked transactions is different in each view:

  • In the standalone popup window, we show the oldest transaction first (in the order they were proposed).
  • In the popup attached to the extension bar, we show the most recent transaction first.
  • As @alextsg mentions above, in the Old UI you can move between the transactions using the element shown, but in the New UI you can't.

I think we should standardize in showing the transactions in the order they were proposed, which also has the security benefit of preventing dapps from proposing a new transaction at the last moment.

We should also include the ability to move between the proposed transactions, as in the old UI.

Could be something as simple as this, although @cjeria should take a look

screen shot 2018-08-22 at 2 30 01 pm

@cjeria
Copy link
Contributor

cjeria commented Aug 30, 2018

Concept for displaying unconfirmed or "stacked" transactions.

image

@bdresser
Copy link

bdresser commented Sep 4, 2018

@alextsg @cjeria would allowing tx confirmation in whatever order the user wants cause nonce issues?

I'm actually ok with the UX as-is, especially since it keeps tx in nonce order -- I just think we should standardize behavior as described above.

Chatted with whymarrh who informed me that nonce is set when a tx is submitted which is cool 😎

Should probably wait until after #3425

@bdresser
Copy link

bdresser commented Apr 2, 2019

this was implemented as part of batch transactions
Screen Shot 2019-04-02 at 11 10 28 AM

@bdresser bdresser closed this as completed Apr 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants