Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New UI: Send Token Screen Improvements #4772

Closed
1 of 2 tasks
danfinlay opened this issue Jul 11, 2018 · 13 comments
Closed
1 of 2 tasks

New UI: Send Token Screen Improvements #4772

danfinlay opened this issue Jul 11, 2018 · 13 comments
Labels
area-UI Relating to the user interface. needs-design Needs design support. type-enhancement

Comments

@danfinlay
Copy link
Contributor

danfinlay commented Jul 11, 2018

@cjeria

We got a user in our support system who was frustrated with our send token screen. In their case, they had an account with many UTK tokens, but no ether, resulting in this experience:

screen shot 2018-07-11 at 9 52 50 am

They were frustrated because they knew they had tokens, and this screen:

  • Should show the relevant token's balance for selected accounts.
  • The "insufficient funds" warning should distinguish between "insufficient ether" and "insufficient tokens".
@danfinlay danfinlay added needs-design Needs design support. area-UI Relating to the user interface. labels Jul 11, 2018
@danjm
Copy link
Contributor

danjm commented Jul 11, 2018

@danfinlay The second item on that list was taken care of by the recently merged: #4694

@cjeria
Copy link
Contributor

cjeria commented Jul 17, 2018

Here's a suggested solution. How about we add an extra dropdown for accounts that hold tokens?

image

@cjeria
Copy link
Contributor

cjeria commented Jul 17, 2018

Accounts that hold tokens will display the dropdown. Accounts selected should still show the ETH/fiat values for gas purposes. The Quantity dropdown should change to token (sorry was being lazy and didn't update that).

@cjeria
Copy link
Contributor

cjeria commented Jul 17, 2018

Here's the flow
image
image
image

@bdresser
Copy link
Contributor

bdresser commented Jul 17, 2018

Looks good @cjeria! Makes sense to show the new row only if the account has tokens. In general I think this will solve a lot of headaches.

  • Will users miss the account switcher in the top-right? I often click "Send," then switch to my relevant account. Could perhaps reduce some padding to help it all fit? Maybe worth some informal interviews.
  • If I am sending ETH from an account with tokens, I might feel weird about the blank field. Why not re-label the field something generic (like "Send" or "Currency") and include ETH as the default option?

@danjm
Copy link
Contributor

danjm commented Jul 27, 2018

@cjeria How should we handle going from a selected token back to ETH? Should the first item in the token dropdown be ETH? Or should there be some sort of deselect button (like an 'X') somewhere?

@cjeria
Copy link
Contributor

cjeria commented Jul 27, 2018

@danjm the first option in the dropdown should be ETH. If the user starts the send flow from a token view, that token should be populated in the token field.

@bdresser
Copy link
Contributor

@cjeria @danjm my only open question is what the label for the form field should be. token isn't really accurate since we're including ETH. currency ? asset ?

I know kyo is busy on other things but I'm happy to get a bounty up if it makes sense.

@cjeria
Copy link
Contributor

cjeria commented Sep 11, 2018

@bdresser maybe coins makes more sense for this category. Coinbase uses this term and categorizes eth under "coins".

@bdresser
Copy link
Contributor

bdresser commented Nov 6, 2018

Per convo with @cjeria, let's start with asset as the label.

Flagging for @omnat - specifically, is anyone confused by showing the asset amount alongside it's ticker symbol in the dropdown? We want to show how much they have, but don't want to make it sound like they're automatically sending the max.

Will move forward with development, can make these tweaks easily once it's in production.

@omnat
Copy link

omnat commented Nov 6, 2018

No one has mentioned it yet in the tests. Could prompt it more in the next tests to see if this is confusing. Will comment if tweaks needed.

@cjeria
Copy link
Contributor

cjeria commented Nov 7, 2018

This insight was uncovered during our first mobile prototype user testing sessions (before @omnat started). I had stitched up the entire send flow and used the same send screen UI as in extension. The whole screen was interactive as well. The reason we haven't seen it in recent tests is because we haven't been looking the send flow very closely.

We'll want to take a closer look at the send screen (with the new token selection option) and entire send flow for both the extension and mobile (crossover insights) in the near future!

@bschorchit
Copy link

closed by #6445

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-UI Relating to the user interface. needs-design Needs design support. type-enhancement
Projects
None yet
Development

No branches or pull requests

8 participants
@danfinlay @cjeria @bdresser @Gudahtt @danjm @bschorchit @omnat and others