Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow currency selection on "Send" screen #3415

Closed
danfinlay opened this issue Mar 3, 2018 · 6 comments
Closed

Allow currency selection on "Send" screen #3415

danfinlay opened this issue Mar 3, 2018 · 6 comments
Assignees
Labels
area-UI Relating to the user interface. needs-design Needs design support. type-enhancement

Comments

@danfinlay
Copy link
Contributor

I know we've talked about this again, but I think it's worth revisiting.

Also suggested again by a user in #3413, proposed with mockups in this google doc.

@danfinlay danfinlay added type-enhancement area-UI Relating to the user interface. needs-design Needs design support. labels Mar 3, 2018
@bdresser
Copy link
Contributor

probably needs to come after #3824

@snreynolds
Copy link

snreynolds commented Jul 12, 2018

If we could allow token selection on the send screen, it could give us room to add the token balances on that screen as mentioned in #4772

@danjm
Copy link
Contributor

danjm commented Jul 27, 2018

@danfinlay can this be closed in favour of #4772 / #4903? Or is this a suggestion that we should allow users to select on the send screen the fiat currency that their ETH / tokens are converted to?

@danfinlay
Copy link
Contributor Author

Nope, it's the asset being sent. Closing in favor of #4772/#4903.

@ghost
Copy link

ghost commented Jul 31, 2018

Do we have the token selection functionality now? Currently, only ETH shows up during the transfer option. This would mean that if I have other tokens and 0 ETH then I get a prompt saying 'insufficient funds'

@bdresser
Copy link
Contributor

@sukuroy this functionality isn't in production yet. The error message you mention is fixed in #4694, and #4772 tracks allowing the user to swap the token they're sending from the currency screen itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-UI Relating to the user interface. needs-design Needs design support. type-enhancement
Projects
None yet
Development

No branches or pull requests

4 participants