Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transactions getting stuck in the "approved" state #4343

Closed
danfinlay opened this issue May 22, 2018 · 7 comments · Fixed by #4557 or #5752
Closed

Transactions getting stuck in the "approved" state #4343

danfinlay opened this issue May 22, 2018 · 7 comments · Fixed by #4557 or #5752
Assignees
@danfinlay @kumavis
Labels
area-transactions type-bug

Comments

@danfinlay
Copy link
Contributor

danfinlay commented May 22, 2018 •
edited
Loading

Approved is the state just before "submitted", which should basically be invisible, because we should submit instantly and reliably. Many users have reported (and I have also experienced) a condition where transactions fall into the "Approved" state, and never progress from there.

This was a previous issue, but I can't find it, so I am creating this to track the issue in the meanwhile.

We should ensure that "approved" transactions are re-tried at least some number of times, and then marked as "failed". Other solutions are welcome.

Somewhat mitigated by #3771.
@danfinlay
Copy link
Contributor Author

We previously thought we had addressed this in #4086.

@danfinlay
Copy link
Contributor Author

This issue is also presented by users in #3942.

@danfinlay
Copy link
Contributor Author

This could be considered a re-opening of #4086, because we have recent reports of this happening.

@danfinlay
Copy link
Contributor Author

People getting frustrated over this bug:
https://www.reddit.com/r/Metamask/comments/8pn8dr/metamask_is_not_sending_transactions/?st=JI7O87RB&sh=abbb7290

@kumavis
Copy link
Member

kumavis commented Jun 12, 2018

so this is most likely related to our mutex getting taken and not released
here is the relevant fix c86f935

there could be other causes of the issue out there, but this is definitely one

@danfinlay
Copy link
Contributor Author

Does that fix work well cherry-picked on its own? Would be great to get it shipped sooner than we might want to ship the provider rewrite.

@kumavis kumavis mentioned this issue Jun 12, 2018
Merged
9 tasks
@kumavis kumavis self-assigned this Jun 12, 2018
@danfinlay danfinlay mentioned this issue Nov 13, 2018
Closed
@danfinlay
Copy link
Contributor Author

We're getting a lot of users reporting transactions that appear submitted that don't get submitted. I got state logs that confirm these transactions are stuck in the APPROVED state. Reopening.

Related to #5739 #4760 #5687

@danfinlay danfinlay reopened this Nov 13, 2018
danfinlay added a commit that referenced this issue Nov 14, 2018
@danfinlay
Resubmit approved transactions on new block
04daa1a 
May fix #4343 and related issues, where an error could leave
transactions stranded in the approved state.
@danfinlay danfinlay mentioned this issue Nov 14, 2018
Merged
@ghost ghost assigned danfinlay Nov 14, 2018
@ghost ghost added the in progress label Nov 14, 2018
@ghost ghost removed the in progress label Nov 14, 2018
frankiebee pushed a commit that referenced this issue Nov 14, 2018
@danfinlay @frankiebee
Resubmit approved transactions on new block (#5752)
22ba0b0 
* Add beginning of test

* Resubmit approved transactions on new block

May fix #4343 and related issues, where an error could leave
transactions stranded in the approved state.

* Remove unused test

* Re-approve transactions when retrying approved

* Add retry approved test

* Include approved in pending tx count

* Fix getPendingTxs()

* Linted

* Only throw hash error in submitted state

* Only check submitted txs for block inclusion

* Fix test expectations
@bdresser bdresser mentioned this issue Nov 19, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danfinlay danfinlay

@kumavis kumavis

Labels
area-transactions type-bug
Projects
None yet
Milestone
No milestone
3 participants
@danfinlay @kumavis @frankiebee