Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New UI: Missing transaction data #3367

Closed
lambi9891 opened this issue Mar 1, 2018 · 11 comments
Closed

New UI: Missing transaction data #3367

lambi9891 opened this issue Mar 1, 2018 · 11 comments
Labels
area-UI Relating to the user interface.

Comments

@lambi9891
Copy link

Cannot add custom transaction data in the new UI

Is the feature missing or am I missing a step ?

@danfinlay
Copy link
Contributor

This was a proposed change from some design research that suggested most people do not use that field. Clearly someone does! Can you describe what you use it for, so we can make sure you're accounted for?

We're currently thinking of adding this as an "advanced mode" feature that you can enable in settings, but is hidden from most users, who tend to be confused by it.

@lambi9891
Copy link
Author

I used twice recently:

  • One was to decide if I wanted or not my tokens to be vested during / slightly after ICO.
  • Another is needed when participating in ICO pools (serves as distribution key I imagine)

Agree with new users being confused. When I was looking for it I naturally opened the "gas settings" icon which actually looks like an "advanced mode" settings. New users don't tend to modify gas settings I imagine.

Maybe you could insert it there ?

@danfinlay
Copy link
Contributor

Those ICOs could just use proper web3 integration, and make it a 1-click tx instead of telling people to copy/paste hex data. That's my favorite solution.

Not sure we'll put it in the gas section, but we'll make sure it's somehow available before the full (non beta) release.

@lambi9891
Copy link
Author

Agree with you.

IMO it still could be a good feature for the user to be able to double check the hex data as it could be an easy malicious attack angle.

@danfinlay
Copy link
Contributor

I agree, the data should be reviewable on the final confirmation screen, and we have open issues for that already.

@bdresser
Copy link
Contributor

bdresser commented Jun 7, 2018

relates to Design#11

@bdresser bdresser added the area-UI Relating to the user interface. label Jun 7, 2018
@1blockologist
Copy link

1blockologist commented Jul 6, 2018

Is there anything I can help with here? In such a way I could submit a PR with this fixed while your team works on the next version of the design

@bdresser
Copy link
Contributor

bdresser commented Jul 6, 2018

@alextsg would a PR be helpful, or is this handled in the confirm screen refactor?

@alextsg
Copy link
Contributor

alextsg commented Jul 6, 2018

@bdresser This will be handled with the confirm screen refactor/redesign and will be merged soon. We're currently working on adding tests.

@bdresser
Copy link
Contributor

bdresser commented Jul 6, 2018

cool - thanks for the offer @1blockologist but this will be released shortly! appreciate your patience.

@bdresser
Copy link
Contributor

this is fixed in #4691 and will be released shortly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-UI Relating to the user interface.
Projects
None yet
Development

No branches or pull requests

5 participants