-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New UI: Missing transaction data #3367
Comments
This was a proposed change from some design research that suggested most people do not use that field. Clearly someone does! Can you describe what you use it for, so we can make sure you're accounted for? We're currently thinking of adding this as an "advanced mode" feature that you can enable in settings, but is hidden from most users, who tend to be confused by it. |
I used twice recently:
Agree with new users being confused. When I was looking for it I naturally opened the "gas settings" icon which actually looks like an "advanced mode" settings. New users don't tend to modify gas settings I imagine. Maybe you could insert it there ? |
Those ICOs could just use proper web3 integration, and make it a 1-click tx instead of telling people to copy/paste hex data. That's my favorite solution. Not sure we'll put it in the gas section, but we'll make sure it's somehow available before the full (non beta) release. |
Agree with you. IMO it still could be a good feature for the user to be able to double check the hex data as it could be an easy malicious attack angle. |
I agree, the data should be reviewable on the final confirmation screen, and we have open issues for that already. |
relates to Design#11 |
Is there anything I can help with here? In such a way I could submit a PR with this fixed while your team works on the next version of the design |
@alextsg would a PR be helpful, or is this handled in the confirm screen refactor? |
@bdresser This will be handled with the confirm screen refactor/redesign and will be merged soon. We're currently working on adding tests. |
cool - thanks for the offer @1blockologist but this will be released shortly! appreciate your patience. |
this is fixed in #4691 and will be released shortly |
Cannot add custom transaction data in the new UI
Is the feature missing or am I missing a step ?
The text was updated successfully, but these errors were encountered: