Modules were missing. #3
Comments
|
thanks! should be resolved now |
yqrashawn
referenced
this issue
in yqrashawn/conflux-portal
Dec 25, 2019
Merge metamask develop branch, fix lint and unit test
SeungjunWe
referenced
this issue
in DcentWallet/metamask-extension
Jul 13, 2020
Automate release publish
meppsilon
pushed a commit
to meppsilon/metamask-extension
that referenced
this issue
Nov 2, 2021
Dynamic refresh rates for smart transactions
12 tasks
7 tasks
github-merge-queue bot
pushed a commit
that referenced
this issue
Dec 16, 2024
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Changes include - layout and styling updates for the landing screen - re-styling input fields, including asset pickers - integrates the multichain asset list into bridge's token list generator - style + copy updates in quote display components - advanced settings modal - input and quote validation alerts - bug fixes This depends on 3 open PRs 1. tracking events: #28713 2. multichain AssetPicker: #28975 3. NetworkAvatar style update: #28976 Changes from #2 and #3 are currently included here, but will mainly just contain bridge component updates after those are merged. Since those are being reviewed by external teams, reviews on this one should be focused on bridge-specific files/directories Figma: https://www.figma.com/design/IuOIRmU3wI0IdJIfol0ESu/Cross-Chain-Swaps?node-id=7-24563&node-type=canvas&m=dev <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [](https://codespaces.new/MetaMask/metamask-extension/pull/28373?quickstart=1) ## **Related issues** Fixes: https://consensyssoftware.atlassian.net/browse/MMS-1451 ## **Manual testing steps** 1. Set these in .metamaskrc and run `yarn webpack --watch` ``` SEGMENT_HOST='http://localhost:9090' SEGMENT_WRITE_KEY='FAKE' BRIDGE_USE_DEV_APIS=1 ``` 2. Try out the Bridge page, asset picker, submitting txs, viewing quotes etc 3. Open the background console network tab to see emitted events ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] -->  ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [X] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [X] I've completed the PR template to the best of my ability - [X] I’ve included tests if applicable - [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [X] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: infiniteflower <[email protected]> Co-authored-by: Jack Clancy <[email protected]>
micaelae
added a commit
that referenced
this issue
Dec 16, 2024
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> Changes include - layout and styling updates for the landing screen - re-styling input fields, including asset pickers - integrates the multichain asset list into bridge's token list generator - style + copy updates in quote display components - advanced settings modal - input and quote validation alerts - bug fixes This depends on 3 open PRs 1. tracking events: #28713 2. multichain AssetPicker: #28975 3. NetworkAvatar style update: #28976 Changes from #2 and #3 are currently included here, but will mainly just contain bridge component updates after those are merged. Since those are being reviewed by external teams, reviews on this one should be focused on bridge-specific files/directories Figma: https://www.figma.com/design/IuOIRmU3wI0IdJIfol0ESu/Cross-Chain-Swaps?node-id=7-24563&node-type=canvas&m=dev <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [](https://codespaces.new/MetaMask/metamask-extension/pull/28373?quickstart=1) Fixes: https://consensyssoftware.atlassian.net/browse/MMS-1451 1. Set these in .metamaskrc and run `yarn webpack --watch` ``` SEGMENT_HOST='http://localhost:9090' SEGMENT_WRITE_KEY='FAKE' BRIDGE_USE_DEV_APIS=1 ``` 2. Try out the Bridge page, asset picker, submitting txs, viewing quotes etc 3. Open the background console network tab to see emitted events <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> <!-- [screenshots/recordings] -->  <!-- [screenshots/recordings] --> - [X] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [X] I've completed the PR template to the best of my ability - [X] I’ve included tests if applicable - [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [X] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: infiniteflower <[email protected]> Co-authored-by: Jack Clancy <[email protected]>
danjm
pushed a commit
that referenced
this issue
Dec 18, 2024
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Changes include - layout and styling updates for the landing screen - re-styling input fields, including asset pickers - integrates the multichain asset list into bridge's token list generator - style + copy updates in quote display components - advanced settings modal - input and quote validation alerts - bug fixes This depends on 3 open PRs 1. tracking events: #28713 2. multichain AssetPicker: #28975 3. NetworkAvatar style update: #28976 Changes from #2 and #3 are currently included here, but will mainly just contain bridge component updates after those are merged. Since those are being reviewed by external teams, reviews on this one should be focused on bridge-specific files/directories Figma: https://www.figma.com/design/IuOIRmU3wI0IdJIfol0ESu/Cross-Chain-Swaps?node-id=7-24563&node-type=canvas&m=dev <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [](https://codespaces.new/MetaMask/metamask-extension/pull/28373?quickstart=1) ## **Related issues** Fixes: https://consensyssoftware.atlassian.net/browse/MMS-1451 ## **Manual testing steps** 1. Set these in .metamaskrc and run `yarn webpack --watch` ``` SEGMENT_HOST='http://localhost:9090' SEGMENT_WRITE_KEY='FAKE' BRIDGE_USE_DEV_APIS=1 ``` 2. Try out the Bridge page, asset picker, submitting txs, viewing quotes etc 3. Open the background console network tab to see emitted events ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] -->  ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [X] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [X] I've completed the PR template to the best of my ability - [X] I’ve included tests if applicable - [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [X] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: infiniteflower <[email protected]> Co-authored-by: Jack Clancy <[email protected]>
ffmcgee725
added a commit
that referenced
this issue
Dec 20, 2024
](https://codespaces.new/MetaMask/metamask-extension/pull/28373?quickstart=1){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
readable-stream
xtend
I assume readable stream needs to be added at the plugin level & xtend needs to be added at the provider package.json?
The text was updated successfully, but these errors were encountered: