Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "Add account should not affect public address when us..." flaky tests #27419

Closed
seaona opened this issue Sep 26, 2024 · 3 comments
Closed

Fix "Add account should not affect public address when us..." flaky tests #27419

seaona opened this issue Sep 26, 2024 · 3 comments
Assignees
@seaona
Labels
area-qa Relating to QA work (Quality Assurance) flaky tests Sev2-normal Normal severity; minor loss of service or inconvenience. team-extension-platform type-bug

Comments

@seaona
Copy link
Contributor

seaona commented Sep 26, 2024

https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/102230/workflows/464f7ef8-7df3-4ed9-80c9-776e71b1297f/jobs/3808841/tests
@seaona seaona added type-bug Sev2-normal Normal severity; minor loss of service or inconvenience. team-extension-platform flaky tests area-qa Relating to QA work (Quality Assurance) labels Sep 26, 2024
@seaona seaona self-assigned this Sep 26, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team Sep 26, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Sep 26, 2024
@seaona seaona mentioned this issue Sep 26, 2024
Merged
7 tasks
hjetpoluru pushed a commit that referenced this issue Sep 26, 2024
@seaona
fix: flaky test `Add account should not affect public address when us…
7a5e4d6 
…ing secret recovery phrase to recover account with non-zero balance @no-mmi`aded (#27420)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**
In the process for creating a new account, we get to see this error:

```
TimeoutError: Waiting for element to be located By(css selector, [data-testid="account-list-menu-details"])
Wait timed out after 10023ms
  (Ran on CircleCI Node 17 of 20, Job test-e2e-chrome)
    at /home/circleci/project/node_modules/selenium-webdriver/lib/webdriver.js:929:17
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
```
This happens after clicking the account menu, and after clicking the Add
account. It seems that the click doesn't hit exactly the button due to
the account list loading, making the button move. When the account list
is loaded, the click is performed outside the button boundary, and this
makes the popup close and you cannot find the next element:
"account-list-menu-details" element.

I haven't been able to reproduce this but I've seen this behaviour in
the manual process

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27420?quickstart=1)

## **Related issues**

Fixes: those 3 are fixed in this PR, as they were caused by the same
issue

- #27419
- #27337
- #27336

## **Manual testing steps**

1. Check ci
2. Run tests locally

## **Screenshots/Recordings**



<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@chloeYue
Copy link
Contributor

wait a bit to close this ticket, we need to verify that the test is not flaky anymore with the fix

@chloeYue chloeYue mentioned this issue Sep 27, 2024
Closed
9 tasks
@seaona
Copy link
Contributor Author

seaona commented Oct 1, 2024

@chloeYue do you think we can close this ticket now? The PR which fixed this and other cases with the same root cause has now been merged. See below:

7a5e4d6

@chloeYue
Copy link
Contributor

chloeYue commented Oct 7, 2024

@chloeYue do you think we can close this ticket now? The PR which fixed this and other cases with the same root cause has now been merged. See below:

7a5e4d6

yes we can close it ! thanks for the fix!

@seaona seaona closed this as completed Oct 7, 2024
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by team Oct 7, 2024
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by severity Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seaona seaona

Labels
area-qa Relating to QA work (Quality Assurance) flaky tests Sev2-normal Normal severity; minor loss of service or inconvenience. team-extension-platform type-bug
Projects
Bugs by severity
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@seaona @chloeYue