Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: yarn:start:test:flask script is broken #25996

Closed
9 tasks
seaona opened this issue Jul 22, 2024 · 0 comments · Fixed by #25995
Closed
9 tasks

chore: yarn:start:test:flask script is broken #25996

seaona opened this issue Jul 22, 2024 · 0 comments · Fixed by #25995
Assignees
@seaona
Labels
area-qa Relating to QA work (Quality Assurance) release-12.3.0 Issue or pull request that will be included in release 12.3.0 team-extension-platform

Comments

@seaona
Copy link
Contributor

seaona commented Jul 22, 2024

What is this about?

start-flask-broken.mp4

Scenario

No response

Design

No response

Technical Details

No response

Threat Modeling Framework

No response

Acceptance Criteria

No response

Stakeholder review needed before the work gets merged

  • Engineering (needed in most cases)
  • Design
  • Product
  • QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
  • Security
  • Legal
  • Marketing
  • Management (please specify)
  • Other (please specify)

References

No response
@seaona seaona self-assigned this Jul 22, 2024
@seaona seaona mentioned this issue Jul 22, 2024
Merged
7 tasks
@seaona seaona changed the title tests: yarn:start:test:flask` script is broken tests: yarn:start:test:flask script is broken Jul 22, 2024
@seaona seaona added the area-qa Relating to QA work (Quality Assurance) label Jul 22, 2024
@seaona seaona changed the title tests: yarn:start:test:flask script is broken chore: yarn:start:test:flask script is broken Jul 22, 2024
seaona added a commit that referenced this issue Jul 22, 2024
@seaona @Mrtenz
fix: yarn:start:test:flask is broken Lavapack is not defined (#25995
e3691c0 
)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

The script `yarn:start:test:flask` is broken and whenever we try to run
a test we get `Lavapack is not defined`. The problem is that we are
adding these 2 flags `--apply-lavamoat=false --snow=false` , which
shouldn't be there, in the same way, we don't use these flags for the ci
flask test build (mv3), which is the reason why this doesn't fail in ci.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/25995?quickstart=1)

## **Related issues**

Fixes: #25996

## **Manual testing steps**

1. Run locally `yarn:start:test:flask` before the fix and run a test -->
see the build is broken
2. Now remove the flags and do it again --> see the build is successful
and tests start running

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**




https://github.com/user-attachments/assets/784a8ab4-4a91-431e-b0bd-322f7f2bfd11



### **After**


https://github.com/user-attachments/assets/0541cae8-f9b3-46e6-84c1-470fd8eee90e





## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: Maarten Zuidhoorn <[email protected]>
@metamaskbot metamaskbot added the release-12.3.0 Issue or pull request that will be included in release 12.3.0 label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seaona seaona

Labels
area-qa Relating to QA work (Quality Assurance) release-12.3.0 Issue or pull request that will be included in release 12.3.0 team-extension-platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: yarn:start:test:flask is broken Lavapack is not defined MetaMask/metamask-extension
2 participants
@metamaskbot @seaona