Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Inconsistency in the behavior between native and non-native tokens during the process of switching tokens #25159

Closed
sleepytanya opened this issue Jun 8, 2024 · 2 comments
Assignees
Labels
send-swap Sev3-low Low severity; minimal to no impact upon users team-wallet-ux type-bug

Comments

@sleepytanya
Copy link
Contributor

Describe the bug

An inconsistency in the behavior between native and non-native tokens during the process of switching tokens.

  1. User sends a native token: when a user changes the destination token from native to non-native and then back to simple send, the destination value is retained
  2. User sends non-native token: if the same actions as above are performed with a non-native origin token, the token amount is not preserved upon switching back to a simple send

Expected behavior

Screenshots/Recordings

Native token:

native.mov

Non-native token:

nonNative.mov

Steps to reproduce

  1. Start send+swap transaction
  2. Select non-native token as an origin
  3. Switch destination token to any other token and then back to initially selected token
  4. Notice the destination value is 0

Error messages or log output

No response

Version

latest send+swap build

Build type

None

Browser

Chrome

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

No response

@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Jun 8, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team Jun 8, 2024
@sleepytanya sleepytanya changed the title [Bug]: [Bug]: Inconsistency in the behavior between native and non-native tokens during the process of switching tokens Jun 8, 2024
@Aliba22
Copy link

Aliba22 commented Jun 8, 2024

Good

@gauthierpetetin gauthierpetetin added the Sev3-low Low severity; minimal to no impact upon users label Jun 10, 2024
@micaelae micaelae self-assigned this Jun 10, 2024
@sleepytanya
Copy link
Contributor Author

Latest v12.0.0 build [https://github.com/MetaMask/metamask-extension/commit/eebc4d5b2284024eaeb190cddfa89990f593ca34]

Consistent behavior while selecting tokens for all ERC20 tokens.

BNB Chain:

bnb.mov

Mainnet:

mainnet.mov

@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by team Jun 22, 2024
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by severity Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
send-swap Sev3-low Low severity; minimal to no impact upon users team-wallet-ux type-bug
Projects
Archived in project
Development

No branches or pull requests

4 participants