Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: swap+send bugs in Version v12.0.0 release #25307

Merged
merged 8 commits into from
Jun 15, 2024

Conversation

micaelae
Copy link
Member

@micaelae micaelae commented Jun 13, 2024

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

Screenshots/Recordings

Before

fiat_before native_before

After

fiat_after native_after

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@micaelae micaelae requested a review from a team as a code owner June 13, 2024 20:05
@micaelae micaelae requested review from BZahory and ejwessel June 13, 2024 20:05
@micaelae micaelae added release-12.0.0 Issue or pull request that will be included in release 12.0.0 team-bridge labels Jun 13, 2024
Copy link

codecov bot commented Jun 13, 2024

Codecov Report

Attention: Patch coverage is 82.35294% with 3 lines in your changes missing coverage. Please review.

Project coverage is 65.38%. Comparing base (2aaf565) to head (9ba153e).
Report is 2 commits behind head on develop.

Files Patch % Lines
ui/hooks/useSwappedTokenValue.js 72.73% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #25307   +/-   ##
========================================
  Coverage    65.37%   65.38%           
========================================
  Files         1377     1377           
  Lines        54623    54632    +9     
  Branches     14320    14326    +6     
========================================
+ Hits         35709    35717    +8     
- Misses       18914    18915    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [cb1e865]
Page Load Metrics (148 ± 189 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint7110790115
domContentLoaded9231331
load421862148393189
domInteractive9231331
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 217 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

BZahory
BZahory previously approved these changes Jun 14, 2024
ejwessel
ejwessel previously approved these changes Jun 14, 2024
@micaelae micaelae dismissed stale reviews from ejwessel and BZahory via e7eaf97 June 14, 2024 19:49
@micaelae micaelae force-pushed the swap-send-25159-25236-24505 branch 2 times, most recently from 9a1bc51 to ae895ee Compare June 14, 2024 20:01
ejwessel
ejwessel previously approved these changes Jun 14, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [9ba153e]
Page Load Metrics (119 ± 161 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint58907584
domContentLoaded9131010
load381581119335161
domInteractive9131010
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 410 Bytes (0.01%)
  • common: 0 Bytes (0.00%)

@micaelae micaelae merged commit 624763a into develop Jun 15, 2024
74 checks passed
@micaelae micaelae deleted the swap-send-25159-25236-24505 branch June 15, 2024 05:41
@github-actions github-actions bot locked and limited conversation to collaborators Jun 15, 2024
@metamaskbot metamaskbot added release-12.1.0 Issue or pull request that will be included in release 12.1.0 and removed release-12.1.0 Issue or pull request that will be included in release 12.1.0 labels Jun 15, 2024
@metamaskbot
Copy link
Collaborator

More than one release label on PR. Keeping the lowest one (release-12.0.0) on PR and removing other release labels (release-12.1.0).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.0.0 Issue or pull request that will be included in release 12.0.0 team-bridge
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants