flaky test: "Backup and Restore should backup the account settings" #24668
Assignees
Labels
flaky tests
release-12.6.0
Issue or pull request that will be included in release 12.6.0
team-extension-platform
Comments
58 tasks
|
This test is still flaky and needs investigation |
9 tasks
7 tasks
github-merge-queue bot
pushed a commit
that referenced
this issue
Oct 2, 2024
…s` (#27565) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Race condition originated when trying to read the backup file. Checking the ci artifacts we can see how [the backup file ](https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/101416/workflows/968f676b-e196-4168-bfb2-47509fe34a59/jobs/3775778/artifacts)was downloaded correctly, so the problem is somewhere in the read/access point. After checking the documentation I've seen that using `fs.access` before reading a file is discouraged as it could cause a race condition:  I've removed that step, and we are now reading the file directly, and added a console.log in the catch block, to get more information in the case the test fails in the reading step, so we can better debug. We can keep monitoring the test in case it fails in the future. So far, it hasn't failed after several local re-runs (and ci with extra x5) [](https://codespaces.new/MetaMask/metamask-extension/pull/27565?quickstart=1) ## **Related issues** Fixes: #24668 ## **Manual testing steps** 1. Check ci 2. Run locally the test ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
](https://codespaces.new/MetaMask/metamask-extension/pull/27565?quickstart=1){kind=link}
metamaskbot
added
the
release-12.6.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What is this about?
Failure:
https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/101416/workflows/968f676b-e196-4168-bfb2-47509fe34a59/jobs/3775778
The text was updated successfully, but these errors were encountered: