Flaky test: "Custom network customNetwork should add mainnet network" #24634
Assignees
Labels
flaky tests
release-12.1.0
Issue or pull request that will be included in release 12.1.0
team-extension-platform
Comments
|
Same error on this flaky test: Custom network Popular Networks List when the network details validation toggle is turned off, don't validate user inserted details
|
58 tasks
7 tasks
DDDDDanica
pushed a commit
that referenced
this issue
Jun 28, 2024
…t network" (#24895) ## **Description** This PR addresses the flakiness in e2e test "Custom network customNetwork should add mainnet network." Root Cause: The flakiness happens due to occasionally hitting the API rate limit while fetching the token symbol, resulting in the warning message `"Ticker symbol verification data is currently unavailable..."`, as indicated by the failure screenshots in the CI job. However, the test is intended to verify the presence of a different warning: `"The token symbol doesn't match the network or chainID..."`. Both warnings share the same data-testid but differ in text. Consequently, when the first warning appears, the test mistakenly identifies it as the second warning, leading to test failure. Fix Implemented: The solution for this test is to refine the selector for the specific warning message we aim to verify. By making the selector more precise, we ensure that the test accurately checks for the intended warning, thereby eliminating the flakiness caused by the confusion between the two warnings.   [](https://codespaces.new/MetaMask/metamask-extension/pull/24895?quickstart=1) ## **Related issues** Fixes: #24634 ## **Manual testing steps** 1. Run the test several times yarn test:e2e:single test/e2e/tests/network/add-custom-network.spec.js --browser=firefox --leave-running --retryUntilFailure --retries=10 2. Check ci jobs ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: seaona <[email protected]>
](https://codespaces.new/MetaMask/metamask-extension/pull/24895?quickstart=1){kind=link}
metamaskbot
added
the
release-12.1.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What is this about?
Failure:
https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/81018/workflows/092574cf-d4e8-4fbd-a5ae-b185ee6b9737/jobs/2868183/tests
Error message
Screenshot
Scenario
No response
Design
No response
Technical Details
No response
Threat Modeling Framework
No response
Acceptance Criteria
No response
Stakeholder review needed before the work gets merged
References
No response
The text was updated successfully, but these errors were encountered: