Flaky Test: Multiple onboarding tests failing due to an error where the "Reveal secret recovery phrase" button cannot be found #24608
Assignees
Labels
flaky tests
release-11.16.6
Issue or pull request that will be included in release 11.16.6
release-12.0.0
Issue or pull request that will be included in release 12.0.0
team-extension-platform
Comments
chloeYue
changed the title
FindingsFor one type of Onboarding failure, this seems to be the error logs. When this error is hit, we stay in the first page and nothing happens. This corresponds to the following failed tests:
|
58 tasks
|
Re-opening as we discovered the problem was not resolved when we thought it was |
7 tasks
danjm
added a commit
that referenced
this issue
May 29, 2024
…ce (#24874) ## **Description** Multiple onboarding tests are flaky, failing with the error `TimeoutError: Waiting for element to be located By(css selector, [data-testid="recovery-phrase-reveal"])` The problem is that the test can get to the page where that selector is present, but then be re-routed back to the previous screen. This is due to a race condition. in create-password.js there is this code: ``` useEffect(() => { if (currentKeyring) { if (firstTimeFlowType === FirstTimeFlowType.import) { ///: BEGIN:ONLY_INCLUDE_IF(build-main,build-beta,build-flask) history.replace(ONBOARDING_COMPLETION_ROUTE); ///: END:ONLY_INCLUDE_IF ///: BEGIN:ONLY_INCLUDE_IF(build-mmi) history.replace(ONBOARDING_PIN_EXTENSION_ROUTE); ///: END:ONLY_INCLUDE_IF } else { ///: BEGIN:ONLY_INCLUDE_IF(build-main,build-beta,build-flask) history.replace(ONBOARDING_SECURE_YOUR_WALLET_ROUTE); ///: END:ONLY_INCLUDE_IF ///: BEGIN:ONLY_INCLUDE_IF(build-mmi) history.replace(SRP_REMINDER); ///: END:ONLY_INCLUDE_IF } } }, [currentKeyring, history, firstTimeFlowType]); ``` and there is this also this code inside handleCreate(): ``` } else { // Otherwise we are in create new wallet flow try { if (createNewAccount) { await createNewAccount(password); } ///: BEGIN:ONLY_INCLUDE_IF(build-main,build-beta,build-flask) history.push(ONBOARDING_SECURE_YOUR_WALLET_ROUTE); ///: END:ONLY_INCLUDE_IF ///: BEGIN:ONLY_INCLUDE_IF(build-mmi) history.replace(SRP_REMINDER); ///: END:ONLY_INCLUDE_IF } catch (error) { setPasswordError(error.message); } ``` What is happening is: 1. user clicks submit/confirm on the create password screen 2. await createNewAccount(password); occurs 3. before that fully resolves, at least a new keyring is created, so the useEffect fires and history.replace(ONBOARDING_SECURE_YOUR_WALLET_ROUTE); so the user/test is taken to the next route and continues with the clicks on the "Secure your wallet" and then "Write down your Secret Recovery Phrase" screen 4. then `await createNewAccount(password);` resolves, and the user/test is rerouted to the "Secure Your Wallet" screen again The fix is to prevent the `history.replace(ONBOARDING_SECURE_YOUR_WALLET_ROUTE)` call in the `useEffect` if `handleCreate` has already started to create a new account [](https://codespaces.new/MetaMask/metamask-extension/pull/24874?quickstart=1) ## **Related issues** Fixes: #24608 ## **Manual testing steps** e2e tests should pass ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
](https://codespaces.new/MetaMask/metamask-extension/pull/24874?quickstart=1){kind=link}
danjm
added a commit
that referenced
this issue
May 31, 2024
…ce (#24874) ## **Description** Multiple onboarding tests are flaky, failing with the error `TimeoutError: Waiting for element to be located By(css selector, [data-testid="recovery-phrase-reveal"])` The problem is that the test can get to the page where that selector is present, but then be re-routed back to the previous screen. This is due to a race condition. in create-password.js there is this code: ``` useEffect(() => { if (currentKeyring) { if (firstTimeFlowType === FirstTimeFlowType.import) { ///: BEGIN:ONLY_INCLUDE_IF(build-main,build-beta,build-flask) history.replace(ONBOARDING_COMPLETION_ROUTE); ///: END:ONLY_INCLUDE_IF ///: BEGIN:ONLY_INCLUDE_IF(build-mmi) history.replace(ONBOARDING_PIN_EXTENSION_ROUTE); ///: END:ONLY_INCLUDE_IF } else { ///: BEGIN:ONLY_INCLUDE_IF(build-main,build-beta,build-flask) history.replace(ONBOARDING_SECURE_YOUR_WALLET_ROUTE); ///: END:ONLY_INCLUDE_IF ///: BEGIN:ONLY_INCLUDE_IF(build-mmi) history.replace(SRP_REMINDER); ///: END:ONLY_INCLUDE_IF } } }, [currentKeyring, history, firstTimeFlowType]); ``` and there is this also this code inside handleCreate(): ``` } else { // Otherwise we are in create new wallet flow try { if (createNewAccount) { await createNewAccount(password); } ///: BEGIN:ONLY_INCLUDE_IF(build-main,build-beta,build-flask) history.push(ONBOARDING_SECURE_YOUR_WALLET_ROUTE); ///: END:ONLY_INCLUDE_IF ///: BEGIN:ONLY_INCLUDE_IF(build-mmi) history.replace(SRP_REMINDER); ///: END:ONLY_INCLUDE_IF } catch (error) { setPasswordError(error.message); } ``` What is happening is: 1. user clicks submit/confirm on the create password screen 2. await createNewAccount(password); occurs 3. before that fully resolves, at least a new keyring is created, so the useEffect fires and history.replace(ONBOARDING_SECURE_YOUR_WALLET_ROUTE); so the user/test is taken to the next route and continues with the clicks on the "Secure your wallet" and then "Write down your Secret Recovery Phrase" screen 4. then `await createNewAccount(password);` resolves, and the user/test is rerouted to the "Secure Your Wallet" screen again The fix is to prevent the `history.replace(ONBOARDING_SECURE_YOUR_WALLET_ROUTE)` call in the `useEffect` if `handleCreate` has already started to create a new account [](https://codespaces.new/MetaMask/metamask-extension/pull/24874?quickstart=1) ## **Related issues** Fixes: #24608 ## **Manual testing steps** e2e tests should pass ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
danjm
added a commit
that referenced
this issue
May 31, 2024
…ce (#24874) ## **Description** Multiple onboarding tests are flaky, failing with the error `TimeoutError: Waiting for element to be located By(css selector, [data-testid="recovery-phrase-reveal"])` The problem is that the test can get to the page where that selector is present, but then be re-routed back to the previous screen. This is due to a race condition. in create-password.js there is this code: ``` useEffect(() => { if (currentKeyring) { if (firstTimeFlowType === FirstTimeFlowType.import) { ///: BEGIN:ONLY_INCLUDE_IF(build-main,build-beta,build-flask) history.replace(ONBOARDING_COMPLETION_ROUTE); ///: END:ONLY_INCLUDE_IF ///: BEGIN:ONLY_INCLUDE_IF(build-mmi) history.replace(ONBOARDING_PIN_EXTENSION_ROUTE); ///: END:ONLY_INCLUDE_IF } else { ///: BEGIN:ONLY_INCLUDE_IF(build-main,build-beta,build-flask) history.replace(ONBOARDING_SECURE_YOUR_WALLET_ROUTE); ///: END:ONLY_INCLUDE_IF ///: BEGIN:ONLY_INCLUDE_IF(build-mmi) history.replace(SRP_REMINDER); ///: END:ONLY_INCLUDE_IF } } }, [currentKeyring, history, firstTimeFlowType]); ``` and there is this also this code inside handleCreate(): ``` } else { // Otherwise we are in create new wallet flow try { if (createNewAccount) { await createNewAccount(password); } ///: BEGIN:ONLY_INCLUDE_IF(build-main,build-beta,build-flask) history.push(ONBOARDING_SECURE_YOUR_WALLET_ROUTE); ///: END:ONLY_INCLUDE_IF ///: BEGIN:ONLY_INCLUDE_IF(build-mmi) history.replace(SRP_REMINDER); ///: END:ONLY_INCLUDE_IF } catch (error) { setPasswordError(error.message); } ``` What is happening is: 1. user clicks submit/confirm on the create password screen 2. await createNewAccount(password); occurs 3. before that fully resolves, at least a new keyring is created, so the useEffect fires and history.replace(ONBOARDING_SECURE_YOUR_WALLET_ROUTE); so the user/test is taken to the next route and continues with the clicks on the "Secure your wallet" and then "Write down your Secret Recovery Phrase" screen 4. then `await createNewAccount(password);` resolves, and the user/test is rerouted to the "Secure Your Wallet" screen again The fix is to prevent the `history.replace(ONBOARDING_SECURE_YOUR_WALLET_ROUTE)` call in the `useEffect` if `handleCreate` has already started to create a new account [](https://codespaces.new/MetaMask/metamask-extension/pull/24874?quickstart=1) ## **Related issues** Fixes: #24608 ## **Manual testing steps** e2e tests should pass ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
danjm
added a commit
that referenced
this issue
May 31, 2024
…ce (#24874) ## **Description** Multiple onboarding tests are flaky, failing with the error `TimeoutError: Waiting for element to be located By(css selector, [data-testid="recovery-phrase-reveal"])` The problem is that the test can get to the page where that selector is present, but then be re-routed back to the previous screen. This is due to a race condition. in create-password.js there is this code: ``` useEffect(() => { if (currentKeyring) { if (firstTimeFlowType === FirstTimeFlowType.import) { ///: BEGIN:ONLY_INCLUDE_IF(build-main,build-beta,build-flask) history.replace(ONBOARDING_COMPLETION_ROUTE); ///: END:ONLY_INCLUDE_IF ///: BEGIN:ONLY_INCLUDE_IF(build-mmi) history.replace(ONBOARDING_PIN_EXTENSION_ROUTE); ///: END:ONLY_INCLUDE_IF } else { ///: BEGIN:ONLY_INCLUDE_IF(build-main,build-beta,build-flask) history.replace(ONBOARDING_SECURE_YOUR_WALLET_ROUTE); ///: END:ONLY_INCLUDE_IF ///: BEGIN:ONLY_INCLUDE_IF(build-mmi) history.replace(SRP_REMINDER); ///: END:ONLY_INCLUDE_IF } } }, [currentKeyring, history, firstTimeFlowType]); ``` and there is this also this code inside handleCreate(): ``` } else { // Otherwise we are in create new wallet flow try { if (createNewAccount) { await createNewAccount(password); } ///: BEGIN:ONLY_INCLUDE_IF(build-main,build-beta,build-flask) history.push(ONBOARDING_SECURE_YOUR_WALLET_ROUTE); ///: END:ONLY_INCLUDE_IF ///: BEGIN:ONLY_INCLUDE_IF(build-mmi) history.replace(SRP_REMINDER); ///: END:ONLY_INCLUDE_IF } catch (error) { setPasswordError(error.message); } ``` What is happening is: 1. user clicks submit/confirm on the create password screen 2. await createNewAccount(password); occurs 3. before that fully resolves, at least a new keyring is created, so the useEffect fires and history.replace(ONBOARDING_SECURE_YOUR_WALLET_ROUTE); so the user/test is taken to the next route and continues with the clicks on the "Secure your wallet" and then "Write down your Secret Recovery Phrase" screen 4. then `await createNewAccount(password);` resolves, and the user/test is rerouted to the "Secure Your Wallet" screen again The fix is to prevent the `history.replace(ONBOARDING_SECURE_YOUR_WALLET_ROUTE)` call in the `useEffect` if `handleCreate` has already started to create a new account [](https://codespaces.new/MetaMask/metamask-extension/pull/24874?quickstart=1) ## **Related issues** Fixes: #24608 ## **Manual testing steps** e2e tests should pass ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
danjm
added a commit
that referenced
this issue
May 31, 2024
…ce (#24874) ## **Description** Multiple onboarding tests are flaky, failing with the error `TimeoutError: Waiting for element to be located By(css selector, [data-testid="recovery-phrase-reveal"])` The problem is that the test can get to the page where that selector is present, but then be re-routed back to the previous screen. This is due to a race condition. in create-password.js there is this code: ``` useEffect(() => { if (currentKeyring) { if (firstTimeFlowType === FirstTimeFlowType.import) { ///: BEGIN:ONLY_INCLUDE_IF(build-main,build-beta,build-flask) history.replace(ONBOARDING_COMPLETION_ROUTE); ///: END:ONLY_INCLUDE_IF ///: BEGIN:ONLY_INCLUDE_IF(build-mmi) history.replace(ONBOARDING_PIN_EXTENSION_ROUTE); ///: END:ONLY_INCLUDE_IF } else { ///: BEGIN:ONLY_INCLUDE_IF(build-main,build-beta,build-flask) history.replace(ONBOARDING_SECURE_YOUR_WALLET_ROUTE); ///: END:ONLY_INCLUDE_IF ///: BEGIN:ONLY_INCLUDE_IF(build-mmi) history.replace(SRP_REMINDER); ///: END:ONLY_INCLUDE_IF } } }, [currentKeyring, history, firstTimeFlowType]); ``` and there is this also this code inside handleCreate(): ``` } else { // Otherwise we are in create new wallet flow try { if (createNewAccount) { await createNewAccount(password); } ///: BEGIN:ONLY_INCLUDE_IF(build-main,build-beta,build-flask) history.push(ONBOARDING_SECURE_YOUR_WALLET_ROUTE); ///: END:ONLY_INCLUDE_IF ///: BEGIN:ONLY_INCLUDE_IF(build-mmi) history.replace(SRP_REMINDER); ///: END:ONLY_INCLUDE_IF } catch (error) { setPasswordError(error.message); } ``` What is happening is: 1. user clicks submit/confirm on the create password screen 2. await createNewAccount(password); occurs 3. before that fully resolves, at least a new keyring is created, so the useEffect fires and history.replace(ONBOARDING_SECURE_YOUR_WALLET_ROUTE); so the user/test is taken to the next route and continues with the clicks on the "Secure your wallet" and then "Write down your Secret Recovery Phrase" screen 4. then `await createNewAccount(password);` resolves, and the user/test is rerouted to the "Secure Your Wallet" screen again The fix is to prevent the `history.replace(ONBOARDING_SECURE_YOUR_WALLET_ROUTE)` call in the `useEffect` if `handleCreate` has already started to create a new account [](https://codespaces.new/MetaMask/metamask-extension/pull/24874?quickstart=1) ## **Related issues** Fixes: #24608 ## **Manual testing steps** e2e tests should pass ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
danjm
added a commit
that referenced
this issue
May 31, 2024
…ce (#24874) ## **Description** Multiple onboarding tests are flaky, failing with the error `TimeoutError: Waiting for element to be located By(css selector, [data-testid="recovery-phrase-reveal"])` The problem is that the test can get to the page where that selector is present, but then be re-routed back to the previous screen. This is due to a race condition. in create-password.js there is this code: ``` useEffect(() => { if (currentKeyring) { if (firstTimeFlowType === FirstTimeFlowType.import) { ///: BEGIN:ONLY_INCLUDE_IF(build-main,build-beta,build-flask) history.replace(ONBOARDING_COMPLETION_ROUTE); ///: END:ONLY_INCLUDE_IF ///: BEGIN:ONLY_INCLUDE_IF(build-mmi) history.replace(ONBOARDING_PIN_EXTENSION_ROUTE); ///: END:ONLY_INCLUDE_IF } else { ///: BEGIN:ONLY_INCLUDE_IF(build-main,build-beta,build-flask) history.replace(ONBOARDING_SECURE_YOUR_WALLET_ROUTE); ///: END:ONLY_INCLUDE_IF ///: BEGIN:ONLY_INCLUDE_IF(build-mmi) history.replace(SRP_REMINDER); ///: END:ONLY_INCLUDE_IF } } }, [currentKeyring, history, firstTimeFlowType]); ``` and there is this also this code inside handleCreate(): ``` } else { // Otherwise we are in create new wallet flow try { if (createNewAccount) { await createNewAccount(password); } ///: BEGIN:ONLY_INCLUDE_IF(build-main,build-beta,build-flask) history.push(ONBOARDING_SECURE_YOUR_WALLET_ROUTE); ///: END:ONLY_INCLUDE_IF ///: BEGIN:ONLY_INCLUDE_IF(build-mmi) history.replace(SRP_REMINDER); ///: END:ONLY_INCLUDE_IF } catch (error) { setPasswordError(error.message); } ``` What is happening is: 1. user clicks submit/confirm on the create password screen 2. await createNewAccount(password); occurs 3. before that fully resolves, at least a new keyring is created, so the useEffect fires and history.replace(ONBOARDING_SECURE_YOUR_WALLET_ROUTE); so the user/test is taken to the next route and continues with the clicks on the "Secure your wallet" and then "Write down your Secret Recovery Phrase" screen 4. then `await createNewAccount(password);` resolves, and the user/test is rerouted to the "Secure Your Wallet" screen again The fix is to prevent the `history.replace(ONBOARDING_SECURE_YOUR_WALLET_ROUTE)` call in the `useEffect` if `handleCreate` has already started to create a new account [](https://codespaces.new/MetaMask/metamask-extension/pull/24874?quickstart=1) ## **Related issues** Fixes: #24608 ## **Manual testing steps** e2e tests should pass ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
danjm
added a commit
that referenced
this issue
Jun 4, 2024
…ce (#24874) ## **Description** Multiple onboarding tests are flaky, failing with the error `TimeoutError: Waiting for element to be located By(css selector, [data-testid="recovery-phrase-reveal"])` The problem is that the test can get to the page where that selector is present, but then be re-routed back to the previous screen. This is due to a race condition. in create-password.js there is this code: ``` useEffect(() => { if (currentKeyring) { if (firstTimeFlowType === FirstTimeFlowType.import) { ///: BEGIN:ONLY_INCLUDE_IF(build-main,build-beta,build-flask) history.replace(ONBOARDING_COMPLETION_ROUTE); ///: END:ONLY_INCLUDE_IF ///: BEGIN:ONLY_INCLUDE_IF(build-mmi) history.replace(ONBOARDING_PIN_EXTENSION_ROUTE); ///: END:ONLY_INCLUDE_IF } else { ///: BEGIN:ONLY_INCLUDE_IF(build-main,build-beta,build-flask) history.replace(ONBOARDING_SECURE_YOUR_WALLET_ROUTE); ///: END:ONLY_INCLUDE_IF ///: BEGIN:ONLY_INCLUDE_IF(build-mmi) history.replace(SRP_REMINDER); ///: END:ONLY_INCLUDE_IF } } }, [currentKeyring, history, firstTimeFlowType]); ``` and there is this also this code inside handleCreate(): ``` } else { // Otherwise we are in create new wallet flow try { if (createNewAccount) { await createNewAccount(password); } ///: BEGIN:ONLY_INCLUDE_IF(build-main,build-beta,build-flask) history.push(ONBOARDING_SECURE_YOUR_WALLET_ROUTE); ///: END:ONLY_INCLUDE_IF ///: BEGIN:ONLY_INCLUDE_IF(build-mmi) history.replace(SRP_REMINDER); ///: END:ONLY_INCLUDE_IF } catch (error) { setPasswordError(error.message); } ``` What is happening is: 1. user clicks submit/confirm on the create password screen 2. await createNewAccount(password); occurs 3. before that fully resolves, at least a new keyring is created, so the useEffect fires and history.replace(ONBOARDING_SECURE_YOUR_WALLET_ROUTE); so the user/test is taken to the next route and continues with the clicks on the "Secure your wallet" and then "Write down your Secret Recovery Phrase" screen 4. then `await createNewAccount(password);` resolves, and the user/test is rerouted to the "Secure Your Wallet" screen again The fix is to prevent the `history.replace(ONBOARDING_SECURE_YOUR_WALLET_ROUTE)` call in the `useEffect` if `handleCreate` has already started to create a new account [](https://codespaces.new/MetaMask/metamask-extension/pull/24874?quickstart=1) ## **Related issues** Fixes: #24608 ## **Manual testing steps** e2e tests should pass ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
metamaskbot
added
the
release-11.16.6
|
Missing release label release-11.16.6 on issue. Adding release label release-11.16.6 on issue, as issue is linked to PR #24874 which has this release label. |
gauthierpetetin
added
the
release-12.0.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What is this about?
Reason of flakiness:
We are trying to find button on wrong screen! Need to check why we are not on expected screen.
Related tests:
Wallet Created Events @no-mmi are sent when onboarding user who chooses to opt in metrics
Wallet Created Events @no-mmi are not sent when onboarding user who chooses to opt out metrics
Failure:
https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/81114/workflows/d532e9e3-0401-4b01-aae7-1682303bc3fe/jobs/2873090/tests
https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/81133/workflows/0b962d69-e9d4-4c3e-9ca0-cfa829b667e2/jobs/2874110/tests
Error message
Screenshot
Scenario
No response
Design
No response
Technical Details
No response
Threat Modeling Framework
No response
Acceptance Criteria
No response
Stakeholder review needed before the work gets merged
References
No response
The text was updated successfully, but these errors were encountered: