[Bug]: MV3 - Transactions - Sending a tx from a dapp triggers errors `failed to create transaction notification` and `Lavamoat: property fetch of globalThis is inaccessible` #24518

seaona · 2024-05-14T13:19:03Z

Describe the bug

Whenever I send a transaction with a lower nonce, I see that MM popup stays loading for more than usual time, and the following background console errors appear:

failed to create transaction notification and
Lavamoat: property fetch of globalThis is inaccessible

Update: it seems this only happens with MV3 build
Update2: the errors seem to appear to all type of tx's (successful and not successful)

Expected behavior

No response

Screenshots/Recordings

failed-create-notification-global-this.mp4

The video below shows what is currently happening in prod: tx fails immediately, popup is closed and no errors above:

nonce-too-low-failed-immediately.mp4

Steps to reproduce

Enable custom nonce from settings
Trigger a tx from a dapp
Set a nonce with lower value
Accept the tx
See how MM popup stays loading for several seconds
See console errors

Error messages or log output

No response

Version

develop with MV3 build

Build type

None

Browser

Chrome

Operating system

Linux

Hardware wallet

No response

Additional context

No response

Severity

No response

The text was updated successfully, but these errors were encountered:

@weizman

…mage util code when creating notifications (#24631) ## **Description** MV3 bug that we needto fix: #24518 In particular, we've got: ``` LavaMoat - property "fetch" of globalThis is inaccessible under scuttling mode. at get (chrome-extension://lbnhnppncgilfagdfbanifbfolodkdaf/scripts/runtime-lavamoat.js:13190:11) at loadImageDataForServiceWorker (extensions::imageUtil:24:22) at loadImageData (extensions::imageUtil:111:5) at Object.loadAllImages (extensions::imageUtil:134:5) at replaceNotificationOptionURLs (extensions::notifications:89:13) at extensions::notifications:116:5 at chrome-extension://lbnhnppncgilfagdfbanifbfolodkdaf/common-6.js:3:431145 at new Promise (<anonymous>) at Proxy.<anonymous> (chrome-extension://lbnhnppncgilfagdfbanifbfolodkdaf/common-6.js:3:430825) at Object.apply (chrome-extension://lbnhnppncgilfagdfbanifbfolodkdaf/common-6.js:3:430244) at Object._showNotification (chrome-extension://lbnhnppncgilfagdfbanifbfolodkdaf/common-2.js:1:455026) ``` The problematic code is in not in our codebase but in chromium, here: https://github.com/chromium/chromium/blob/main/extensions/renderer/resources/image_util.js#L23-L25 You can see that function is named loadImageDataForServiceWorker and it is only used in mv3. This breaks the browser notification feature. As can be seen from the commit history and the comments in this PR, we attemtped some solutions that would allow us to provide a modified and tamed fetch to be used for this image fetching. However, there are unknown problems - related to how sentry uses fetch and how sentry is initialized - that interfere with the solutions we attempted. So for now, as discussed with @weizman, the latest commit on the PR just adds a scuttling exception for fetch (and for Offscreen Canvas, which is also needed for the browser notification feature). We will return to the root problem later, and aim to remove these scuttling exceptions. ## **Related issues** Fixes: #24518 ## **Manual testing steps** 1. `yarn dist:mv3` 2. install, onboard 3. send a transaction 4. verify that a browser notification is shown once the transaction is confirmed ## **Screenshots/Recordings**  ### **Before**  ### **After**  ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@weizman

…mage util code when creating notifications (#24631) ## **Description** MV3 bug that we needto fix: #24518 In particular, we've got: ``` LavaMoat - property "fetch" of globalThis is inaccessible under scuttling mode. at get (chrome-extension://lbnhnppncgilfagdfbanifbfolodkdaf/scripts/runtime-lavamoat.js:13190:11) at loadImageDataForServiceWorker (extensions::imageUtil:24:22) at loadImageData (extensions::imageUtil:111:5) at Object.loadAllImages (extensions::imageUtil:134:5) at replaceNotificationOptionURLs (extensions::notifications:89:13) at extensions::notifications:116:5 at chrome-extension://lbnhnppncgilfagdfbanifbfolodkdaf/common-6.js:3:431145 at new Promise (<anonymous>) at Proxy.<anonymous> (chrome-extension://lbnhnppncgilfagdfbanifbfolodkdaf/common-6.js:3:430825) at Object.apply (chrome-extension://lbnhnppncgilfagdfbanifbfolodkdaf/common-6.js:3:430244) at Object._showNotification (chrome-extension://lbnhnppncgilfagdfbanifbfolodkdaf/common-2.js:1:455026) ``` The problematic code is in not in our codebase but in chromium, here: https://github.com/chromium/chromium/blob/main/extensions/renderer/resources/image_util.js#L23-L25 You can see that function is named loadImageDataForServiceWorker and it is only used in mv3. This breaks the browser notification feature. As can be seen from the commit history and the comments in this PR, we attemtped some solutions that would allow us to provide a modified and tamed fetch to be used for this image fetching. However, there are unknown problems - related to how sentry uses fetch and how sentry is initialized - that interfere with the solutions we attempted. So for now, as discussed with @weizman, the latest commit on the PR just adds a scuttling exception for fetch (and for Offscreen Canvas, which is also needed for the browser notification feature). We will return to the root problem later, and aim to remove these scuttling exceptions. ## **Related issues** Fixes: #24518 ## **Manual testing steps** 1. `yarn dist:mv3` 2. install, onboard 3. send a transaction 4. verify that a browser notification is shown once the transaction is confirmed ## **Screenshots/Recordings**  ### **Before**  ### **After**  ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@weizman

…mage util code when creating notifications (#24631) ## **Description** MV3 bug that we needto fix: #24518 In particular, we've got: ``` LavaMoat - property "fetch" of globalThis is inaccessible under scuttling mode. at get (chrome-extension://lbnhnppncgilfagdfbanifbfolodkdaf/scripts/runtime-lavamoat.js:13190:11) at loadImageDataForServiceWorker (extensions::imageUtil:24:22) at loadImageData (extensions::imageUtil:111:5) at Object.loadAllImages (extensions::imageUtil:134:5) at replaceNotificationOptionURLs (extensions::notifications:89:13) at extensions::notifications:116:5 at chrome-extension://lbnhnppncgilfagdfbanifbfolodkdaf/common-6.js:3:431145 at new Promise (<anonymous>) at Proxy.<anonymous> (chrome-extension://lbnhnppncgilfagdfbanifbfolodkdaf/common-6.js:3:430825) at Object.apply (chrome-extension://lbnhnppncgilfagdfbanifbfolodkdaf/common-6.js:3:430244) at Object._showNotification (chrome-extension://lbnhnppncgilfagdfbanifbfolodkdaf/common-2.js:1:455026) ``` The problematic code is in not in our codebase but in chromium, here: https://github.com/chromium/chromium/blob/main/extensions/renderer/resources/image_util.js#L23-L25 You can see that function is named loadImageDataForServiceWorker and it is only used in mv3. This breaks the browser notification feature. As can be seen from the commit history and the comments in this PR, we attemtped some solutions that would allow us to provide a modified and tamed fetch to be used for this image fetching. However, there are unknown problems - related to how sentry uses fetch and how sentry is initialized - that interfere with the solutions we attempted. So for now, as discussed with @weizman, the latest commit on the PR just adds a scuttling exception for fetch (and for Offscreen Canvas, which is also needed for the browser notification feature). We will return to the root problem later, and aim to remove these scuttling exceptions. ## **Related issues** Fixes: #24518 ## **Manual testing steps** 1. `yarn dist:mv3` 2. install, onboard 3. send a transaction 4. verify that a browser notification is shown once the transaction is confirmed ## **Screenshots/Recordings**  ### **Before**  ### **After**  ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@weizman

…mage util code when creating notifications (#24631) ## **Description** MV3 bug that we needto fix: #24518 In particular, we've got: ``` LavaMoat - property "fetch" of globalThis is inaccessible under scuttling mode. at get (chrome-extension://lbnhnppncgilfagdfbanifbfolodkdaf/scripts/runtime-lavamoat.js:13190:11) at loadImageDataForServiceWorker (extensions::imageUtil:24:22) at loadImageData (extensions::imageUtil:111:5) at Object.loadAllImages (extensions::imageUtil:134:5) at replaceNotificationOptionURLs (extensions::notifications:89:13) at extensions::notifications:116:5 at chrome-extension://lbnhnppncgilfagdfbanifbfolodkdaf/common-6.js:3:431145 at new Promise (<anonymous>) at Proxy.<anonymous> (chrome-extension://lbnhnppncgilfagdfbanifbfolodkdaf/common-6.js:3:430825) at Object.apply (chrome-extension://lbnhnppncgilfagdfbanifbfolodkdaf/common-6.js:3:430244) at Object._showNotification (chrome-extension://lbnhnppncgilfagdfbanifbfolodkdaf/common-2.js:1:455026) ``` The problematic code is in not in our codebase but in chromium, here: https://github.com/chromium/chromium/blob/main/extensions/renderer/resources/image_util.js#L23-L25 You can see that function is named loadImageDataForServiceWorker and it is only used in mv3. This breaks the browser notification feature. As can be seen from the commit history and the comments in this PR, we attemtped some solutions that would allow us to provide a modified and tamed fetch to be used for this image fetching. However, there are unknown problems - related to how sentry uses fetch and how sentry is initialized - that interfere with the solutions we attempted. So for now, as discussed with @weizman, the latest commit on the PR just adds a scuttling exception for fetch (and for Offscreen Canvas, which is also needed for the browser notification feature). We will return to the root problem later, and aim to remove these scuttling exceptions. ## **Related issues** Fixes: #24518 ## **Manual testing steps** 1. `yarn dist:mv3` 2. install, onboard 3. send a transaction 4. verify that a browser notification is shown once the transaction is confirmed ## **Screenshots/Recordings**  ### **Before**  ### **After**  ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@weizman

…mage util code when creating notifications (#24631) ## **Description** MV3 bug that we needto fix: #24518 In particular, we've got: ``` LavaMoat - property "fetch" of globalThis is inaccessible under scuttling mode. at get (chrome-extension://lbnhnppncgilfagdfbanifbfolodkdaf/scripts/runtime-lavamoat.js:13190:11) at loadImageDataForServiceWorker (extensions::imageUtil:24:22) at loadImageData (extensions::imageUtil:111:5) at Object.loadAllImages (extensions::imageUtil:134:5) at replaceNotificationOptionURLs (extensions::notifications:89:13) at extensions::notifications:116:5 at chrome-extension://lbnhnppncgilfagdfbanifbfolodkdaf/common-6.js:3:431145 at new Promise (<anonymous>) at Proxy.<anonymous> (chrome-extension://lbnhnppncgilfagdfbanifbfolodkdaf/common-6.js:3:430825) at Object.apply (chrome-extension://lbnhnppncgilfagdfbanifbfolodkdaf/common-6.js:3:430244) at Object._showNotification (chrome-extension://lbnhnppncgilfagdfbanifbfolodkdaf/common-2.js:1:455026) ``` The problematic code is in not in our codebase but in chromium, here: https://github.com/chromium/chromium/blob/main/extensions/renderer/resources/image_util.js#L23-L25 You can see that function is named loadImageDataForServiceWorker and it is only used in mv3. This breaks the browser notification feature. As can be seen from the commit history and the comments in this PR, we attemtped some solutions that would allow us to provide a modified and tamed fetch to be used for this image fetching. However, there are unknown problems - related to how sentry uses fetch and how sentry is initialized - that interfere with the solutions we attempted. So for now, as discussed with @weizman, the latest commit on the PR just adds a scuttling exception for fetch (and for Offscreen Canvas, which is also needed for the browser notification feature). We will return to the root problem later, and aim to remove these scuttling exceptions. ## **Related issues** Fixes: #24518 ## **Manual testing steps** 1. `yarn dist:mv3` 2. install, onboard 3. send a transaction 4. verify that a browser notification is shown once the transaction is confirmed ## **Screenshots/Recordings**  ### **Before**  ### **After**  ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@weizman

…mage util code when creating notifications (#24631) ## **Description** MV3 bug that we needto fix: #24518 In particular, we've got: ``` LavaMoat - property "fetch" of globalThis is inaccessible under scuttling mode. at get (chrome-extension://lbnhnppncgilfagdfbanifbfolodkdaf/scripts/runtime-lavamoat.js:13190:11) at loadImageDataForServiceWorker (extensions::imageUtil:24:22) at loadImageData (extensions::imageUtil:111:5) at Object.loadAllImages (extensions::imageUtil:134:5) at replaceNotificationOptionURLs (extensions::notifications:89:13) at extensions::notifications:116:5 at chrome-extension://lbnhnppncgilfagdfbanifbfolodkdaf/common-6.js:3:431145 at new Promise (<anonymous>) at Proxy.<anonymous> (chrome-extension://lbnhnppncgilfagdfbanifbfolodkdaf/common-6.js:3:430825) at Object.apply (chrome-extension://lbnhnppncgilfagdfbanifbfolodkdaf/common-6.js:3:430244) at Object._showNotification (chrome-extension://lbnhnppncgilfagdfbanifbfolodkdaf/common-2.js:1:455026) ``` The problematic code is in not in our codebase but in chromium, here: https://github.com/chromium/chromium/blob/main/extensions/renderer/resources/image_util.js#L23-L25 You can see that function is named loadImageDataForServiceWorker and it is only used in mv3. This breaks the browser notification feature. As can be seen from the commit history and the comments in this PR, we attemtped some solutions that would allow us to provide a modified and tamed fetch to be used for this image fetching. However, there are unknown problems - related to how sentry uses fetch and how sentry is initialized - that interfere with the solutions we attempted. So for now, as discussed with @weizman, the latest commit on the PR just adds a scuttling exception for fetch (and for Offscreen Canvas, which is also needed for the browser notification feature). We will return to the root problem later, and aim to remove these scuttling exceptions. ## **Related issues** Fixes: #24518 ## **Manual testing steps** 1. `yarn dist:mv3` 2. install, onboard 3. send a transaction 4. verify that a browser notification is shown once the transaction is confirmed ## **Screenshots/Recordings**  ### **Before**  ### **After**  ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

metamaskbot · 2024-06-04T20:07:26Z

Missing release label release-11.16.6 on issue. Adding release label release-11.16.6 on issue, as issue is linked to PR #24631 which has this release label.

seaona added the type-bug label May 14, 2024

github-project-automation bot added this to Bugs by severity and Bugs by team May 14, 2024

github-project-automation bot moved this to To be fixed in Bugs by severity May 14, 2024

github-project-automation bot moved this to To be fixed in Bugs by team May 14, 2024

seaona added the Sev2-normal Normal severity; minor loss of service or inconvenience. label May 14, 2024

DanielTech21 added the team-wallet-ux label May 14, 2024

seaona added MV3 team-extension-platform and removed team-wallet-ux labels May 14, 2024

gauthierpetetin assigned vthomas13 May 14, 2024

danjm mentioned this issue May 23, 2024

fix: Add scuttle exception for fetch because it is used by chromium image util code when creating notifications #24631

Merged

7 tasks

danjm closed this as completed in #24631 May 23, 2024

github-project-automation bot moved this from To be fixed to Fixed in Bugs by severity May 23, 2024

github-project-automation bot moved this from To be fixed to Fixed in Bugs by team May 23, 2024

metamaskbot added the release-11.18.0 label May 23, 2024

metamaskbot added the release-11.16.6 Issue or pull request that will be included in release 11.16.6 label Jun 4, 2024

gauthierpetetin added the release-12.0.0 Issue or pull request that will be included in release 12.0.0 label Jun 6, 2024

gauthierpetetin removed this from Bugs by team Jul 10, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Bug]: MV3 - Transactions - Sending a tx from a dapp triggers errors `failed to create transaction notification` and `Lavamoat: property fetch of globalThis is inaccessible` #24518

[Bug]: MV3 - Transactions - Sending a tx from a dapp triggers errors `failed to create transaction notification` and `Lavamoat: property fetch of globalThis is inaccessible` #24518

seaona commented May 14, 2024 •

edited

Loading

metamaskbot commented Jun 4, 2024

[Bug]: MV3 - Transactions - Sending a tx from a dapp triggers errors failed to create transaction notification and Lavamoat: property fetch of globalThis is inaccessible #24518

[Bug]: MV3 - Transactions - Sending a tx from a dapp triggers errors failed to create transaction notification and Lavamoat: property fetch of globalThis is inaccessible #24518

Comments

seaona commented May 14, 2024 • edited Loading

Describe the bug

Expected behavior

Screenshots/Recordings

Steps to reproduce

Error messages or log output

Version

Build type

Browser

Operating system

Hardware wallet

Additional context

Severity

metamaskbot commented Jun 4, 2024

[Bug]: MV3 - Transactions - Sending a tx from a dapp triggers errors `failed to create transaction notification` and `Lavamoat: property fetch of globalThis is inaccessible` #24518

[Bug]: MV3 - Transactions - Sending a tx from a dapp triggers errors `failed to create transaction notification` and `Lavamoat: property fetch of globalThis is inaccessible` #24518

seaona commented May 14, 2024 •

edited

Loading