[Bug]: Incorrect Fiat total on confirmations screen #23515
Labels
regression-prod-11.12.0
Regression bug that was found in production in release 11.12.0
release-11.12.2
Issue or pull request that will be included in release 11.12.2
release-11.14.0
Issue or pull request that will be included in release 11.14.0
Sev1-high
High severity; partial loss of service with severe impact upon users, with no workaround.
team-confirmations
Push issues to confirmations team
team-confirmations-planning
(only for internal use within Confirmations team)
team-confirmations-secure-ux
DEPRECATED: please use "team-confirmations" label instead
type-bug
Comments
gauthierpetetin
added
Sev1-high
metamaskbot
added
the
regression-prod-11.12.0
matthewwalsh0
removed
the
team-confirmations-system
13 tasks
danjm
added a commit
that referenced
this issue
Mar 15, 2024
## **Description** This PR corrects the display of the "Total" value under the "Fee Details" dropdown. It also ensures the "Fee details" dropdown is only shown on layer 2 networks. This is the correct spec, as confirmed with @bschorchit ## **Related issues** Fixes: #23515 ## **Manual testing steps** 1. On eth mainnet, create a transaction 2. There should be no "Fee details" dropdown, and other fee information should be correct. 1. On Optimism, create a transaction 2. Their should be a fee details, and opening it should show a Total that matches the estimated total shown below/outside the "fee details" section ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** Layer 1  Layer 2  ### **After** Layer 1  Layer 2  ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've clearly explained what problem this PR is solving and how it is solved. - [ ] I've linked related issues - [ ] I've included manual testing steps - [ ] I've included screenshots/recordings if applicable - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: Dan J Miller <[email protected]>
metamaskbot
added
the
release-11.14.0
danjm
added a commit
that referenced
this issue
Mar 15, 2024
This PR corrects the display of the "Total" value under the "Fee Details" dropdown. It also ensures the "Fee details" dropdown is only shown on layer 2 networks. This is the correct spec, as confirmed with @bschorchit Fixes: #23515 1. On eth mainnet, create a transaction 2. There should be no "Fee details" dropdown, and other fee information should be correct. 1. On Optimism, create a transaction 2. Their should be a fee details, and opening it should show a Total that matches the estimated total shown below/outside the "fee details" section <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> Layer 1  Layer 2  Layer 1  Layer 2  - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've clearly explained what problem this PR is solving and how it is solved. - [ ] I've linked related issues - [ ] I've included manual testing steps - [ ] I've included screenshots/recordings if applicable - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft". - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: Dan J Miller <[email protected]>
metamaskbot
added
the
release-11.12.2
|
Missing release label release-11.12.2 on issue. Adding release label release-11.12.2 on issue, as issue is linked to PR #23524 which has this release label. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
I wanted to participate to a free NFT mint on this website.
When I click on "Claim Now", I encounter two issues:
Expected behavior
Screenshots/Recordings
Steps to reproduce
Error messages or log output
No response
Version
11.12.0
Build type
None
Browser
Chrome
Operating system
MacOS
Hardware wallet
No response
Additional context
No response
Severity
The text was updated successfully, but these errors were encountered: