[Bug]: Suggested ticker symbol displaying on already added popular network #22491
Assignees
Labels
area-customNetworks
regression-prod-11.7.2
Regression bug that was found in production in release 11.7.2
release-11.13.0
Issue or pull request that will be included in release 11.13.0
Sev3-low
Low severity; minimal to no impact upon users
team-assets
type-bug
Comments
kevinghim
added
type-bug
Sev3-low
metamaskbot
added
the
regression-prod-11.7.2
kevinghim
added
team-assets
and removed
team-extension-ux
13 tasks
salimtb
added a commit
that referenced
this issue
Feb 27, 2024
## **Description** When you go to the popular network list, on an already existing network, the "Suggested ticker symbol: [symbol name]" appears. This should only appear with new added custom networks. The suggestion is also duplicating the exact symbol that's been already added. ## **Related issues** Fixes: #22491 ## **Manual testing steps** 1. Go to popular network 2. Try to add one of them 3. go to edit network form 4. the Symbol will be suggested ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> <img width="1100" alt="Screenshot 2024-02-26 at 13 41 19" src="https://github.com/MetaMask/metamask-extension/assets/26223211/0c8b2ad2-5415-4b2c-b529-574947a56146"> ### **After** <!-- [screenshots/recordings] --> <img width="1124" alt="Screenshot 2024-02-26 at 13 39 55" src="https://github.com/MetaMask/metamask-extension/assets/26223211/8cf1ce5f-a955-474a-9951-0a55946209b2"> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've clearly explained what problem this PR is solving and how it is solved. - [x] I've linked related issues - [x] I've included manual testing steps - [x] I've included screenshots/recordings if applicable - [x] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [x] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [x] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
metamaskbot
added
the
release-11.13.0
dbrans
pushed a commit
that referenced
this issue
Feb 27, 2024
## **Description** When you go to the popular network list, on an already existing network, the "Suggested ticker symbol: [symbol name]" appears. This should only appear with new added custom networks. The suggestion is also duplicating the exact symbol that's been already added. ## **Related issues** Fixes: #22491 ## **Manual testing steps** 1. Go to popular network 2. Try to add one of them 3. go to edit network form 4. the Symbol will be suggested ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> <img width="1100" alt="Screenshot 2024-02-26 at 13 41 19" src="https://github.com/MetaMask/metamask-extension/assets/26223211/0c8b2ad2-5415-4b2c-b529-574947a56146"> ### **After** <!-- [screenshots/recordings] --> <img width="1124" alt="Screenshot 2024-02-26 at 13 39 55" src="https://github.com/MetaMask/metamask-extension/assets/26223211/8cf1ce5f-a955-474a-9951-0a55946209b2"> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've clearly explained what problem this PR is solving and how it is solved. - [x] I've linked related issues - [x] I've included manual testing steps - [x] I've included screenshots/recordings if applicable - [x] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [x] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [x] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
When you go to the popular network list, on an already existing network, the "Suggested ticker symbol: [symbol name]" appears. This should only appear with new added custom networks.
The suggestion is also duplicating the exact symbol that's been already added.
Expected behavior
No response
Screenshots/Recordings
Steps to reproduce
Error messages or log output
No response
Version
11.7.2
Build type
None
Browser
Chrome
Operating system
MacOS
Hardware wallet
No response
Additional context
No response
Severity
No response
The text was updated successfully, but these errors were encountered: