Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Error when trying to speed or cancel transaction on Firefox. #22314

Closed
sleepytanya opened this issue Dec 18, 2023 · 2 comments · Fixed by MetaMask/core#3800 or #22943
Closed

[Bug]: Error when trying to speed or cancel transaction on Firefox. #22314

sleepytanya opened this issue Dec 18, 2023 · 2 comments · Fixed by MetaMask/core#3800 or #22943
Assignees
@OGPoyraz
Labels
regression-prod-11.8.0 Regression bug that was found in production in release 11.8.0 regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead regression-RC-11.8.0 release-11.8.0 Issue or pull request that will be included in release 11.8.0 release-11.13.0 Issue or pull request that will be included in release 11.13.0 Sev2-normal Normal severity; minor loss of service or inconvenience. team-confirmations-system DEPRECATED: please use "team-confirmations" label instead type-bug

Comments

@sleepytanya
Copy link
Contributor

Describe the bug

Every time when transaction is sped up or cancelled you can the error in the background console.

Expected behavior

There should be no error.

Screenshots/Recordings

Sepolia:

firefox_sepolia.mov

Linea Goerli:

firefox_linea.mov

Errors are the same for speeding up and cancelling:
Screenshot 2023-12-18 at 12 57 49 AM

Steps to reproduce

  1. Connect to Sepolia or Linea Goerli testnet
  2. Send regular Eth transaction or deploy the contract with low gas setting so you have time to speed it up or cancel
  3. Try to speed up / cancel
  4. See the error message in the background console

Error messages or log output

No response

Version

11.8.0

Build type

None

Browser

Firefox

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

No response
@metamaskbot metamaskbot added the regression-prod-11.8.0 Regression bug that was found in production in release 11.8.0 label Dec 18, 2023
@sleepytanya
Copy link
Contributor Author

sleepytanya commented Dec 18, 2023 •
edited
Loading

MetaMask 11.6.2 Firefox - I still see the errors when trying to speed up / cancel transaction but they are different from 11.8.0 errors. UI for cancelled transaction looks different.
Screenshot 2023-12-18 at 9 43 43 AM
Screenshot 2023-12-18 at 9 42 49 AM
Screenshot 2023-12-18 at 9 41 12 AM
Screenshot 2023-12-18 at 9 43 19 AM

@benjisclowder benjisclowder mentioned this issue Dec 19, 2023
Merged
@benjisclowder
Copy link
Contributor

benjisclowder commented Dec 19, 2023 •
edited
Loading

This is what I got in two different instances of Firefox, on Sepolia. Steps: Deploy erc20 contract --> approve tokens --> transaction is stuck on pending and in the end it does get confirmed but this error shows up both in speeding up and cancelling the pending tx.

image

Screen.Recording.2023-12-19.at.13.38.15.mov

@anaamolnar anaamolnar added team-confirmations-system DEPRECATED: please use "team-confirmations" label instead Sev2-normal Normal severity; minor loss of service or inconvenience. labels Dec 19, 2023
@sleepytanya sleepytanya mentioned this issue Dec 19, 2023
Closed
@metamaskbot metamaskbot added regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead release-11.8.0 Issue or pull request that will be included in release 11.8.0 labels Jan 4, 2024
@OGPoyraz OGPoyraz self-assigned this Jan 17, 2024
@OGPoyraz OGPoyraz linked a pull request Jan 19, 2024 that will close this issue
Check pending txs before submitting cancel MetaMask/core#3800
Merged
3 tasks
@OGPoyraz OGPoyraz mentioned this issue Jan 22, 2024
Merged
3 tasks
@OGPoyraz OGPoyraz mentioned this issue Feb 5, 2024
Closed
OGPoyraz added a commit to MetaMask/core that referenced this issue Feb 13, 2024
@OGPoyraz @matthewwalsh0
Check pending txs before submitting cancel (#3800)
81ac379 
## Explanation

This PR updates `speedUp` and `cancel` transactions to force checking
pending transaction statuses before creating each transaction.

## References

* Fixes MetaMask/metamask-extension#22314

## Changelog

### `@metamask/transaction-controller`

- **Added**: Added a call of
`PendingTransactionTracker.checkTransactions` before creating speed-up
and cancel transactions

## Checklist

- [x] I've updated the test suite for new or updated code as appropriate
- [x] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [ ] I've highlighted breaking changes using the "BREAKING" category
above as appropriate

---------

Co-authored-by: Matthew Walsh <[email protected]>
@OGPoyraz OGPoyraz mentioned this issue Feb 14, 2024
Merged
13 tasks
MajorLift pushed a commit to MetaMask/core that referenced this issue Feb 16, 2024
@OGPoyraz @matthewwalsh0 @MajorLift
Check pending txs before submitting cancel (#3800)
a38771f 
## Explanation

This PR updates `speedUp` and `cancel` transactions to force checking
pending transaction statuses before creating each transaction.

## References

* Fixes MetaMask/metamask-extension#22314

## Changelog

### `@metamask/transaction-controller`

- **Added**: Added a call of
`PendingTransactionTracker.checkTransactions` before creating speed-up
and cancel transactions

## Checklist

- [x] I've updated the test suite for new or updated code as appropriate
- [x] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [ ] I've highlighted breaking changes using the "BREAKING" category
above as appropriate

---------

Co-authored-by: Matthew Walsh <[email protected]>
OGPoyraz added a commit that referenced this issue Feb 23, 2024
@OGPoyraz @metamaskbot
Show modal when user tries to cancel confirmed transaction (#22943)
37227c4 
## **Description**

If user tries to cancel transaction which is already confirmed, we would
like to show them a modal to show a link to block explorer.

## **Related issues**

Fixes: #22314
Related: #22663

## **Manual testing steps**

Please see the recording. 

## **Screenshots/Recordings**


https://github.com/MetaMask/metamask-extension/assets/7644512/861ef616-89a4-4292-8a2b-8a1733f2d88b

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've clearly explained what problem this PR is solving and how it
is solved.
- [x] I've linked related issues
- [x] I've included manual testing steps
- [x] I've included screenshots/recordings if applicable
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
- [ ] I’ve properly set the pull request status:
  - [ ] In case it's not yet "ready for review", I've set it to "draft".
- [ ] In case it's "ready for review", I've changed it from "draft" to
"non-draft".

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: MetaMask Bot <[email protected]>
@metamaskbot metamaskbot added the release-11.13.0 Issue or pull request that will be included in release 11.13.0 label Feb 23, 2024
dbrans pushed a commit that referenced this issue Feb 27, 2024
@OGPoyraz @metamaskbot @dbrans
Show modal when user tries to cancel confirmed transaction (#22943)
a93967f 
## **Description**

If user tries to cancel transaction which is already confirmed, we would
like to show them a modal to show a link to block explorer.

## **Related issues**

Fixes: #22314
Related: #22663

## **Manual testing steps**

Please see the recording. 

## **Screenshots/Recordings**


https://github.com/MetaMask/metamask-extension/assets/7644512/861ef616-89a4-4292-8a2b-8a1733f2d88b

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've clearly explained what problem this PR is solving and how it
is solved.
- [x] I've linked related issues
- [x] I've included manual testing steps
- [x] I've included screenshots/recordings if applicable
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
- [ ] I’ve properly set the pull request status:
  - [ ] In case it's not yet "ready for review", I've set it to "draft".
- [ ] In case it's "ready for review", I've changed it from "draft" to
"non-draft".

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: MetaMask Bot <[email protected]>
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team Apr 9, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity May 15, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OGPoyraz OGPoyraz

Labels
regression-prod-11.8.0 Regression bug that was found in production in release 11.8.0 regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead regression-RC-11.8.0 release-11.8.0 Issue or pull request that will be included in release 11.8.0 release-11.13.0 Issue or pull request that will be included in release 11.13.0 Sev2-normal Normal severity; minor loss of service or inconvenience. team-confirmations-system DEPRECATED: please use "team-confirmations" label instead type-bug
Projects
None yet
Milestone
No milestone
5 participants
@OGPoyraz @metamaskbot @anaamolnar @sleepytanya @benjisclowder