Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: showing the name and params of a contract method that's being called #2152

Closed
macbem opened this issue Sep 22, 2017 · 2 comments
Closed

Feature request: showing the name and params of a contract method that's being called #2152

macbem opened this issue Sep 22, 2017 · 2 comments
Labels
area-UI Relating to the user interface. type-enhancement

Comments

@macbem
Copy link

macbem commented Sep 22, 2017

As in the title, it would be nice to be able to confirm what contract method the Dapp is calling on our behalf before we confirm the tx.

Params wouldn't be necessary, but the method name would make tech-savvy users feel safer when using Dapps - for example, how am I supposed to know that a contract isn't calling approve on some other token's contract to later steal my funds?
@bdresser
Copy link
Contributor

bdresser commented Jun 8, 2018

@macbem this is being tackled in MetaMask/Design#11 and MetaMask/Design#18 if you're still interested :)

@bdresser bdresser added type-enhancement P2-sooner area-UI Relating to the user interface. labels Jun 8, 2018
@bdresser
Copy link
Contributor

this feature is added in #4691

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-UI Relating to the user interface. type-enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bdresser @macbem