Fix flaky test "does not try to get contract method name from 4byte when the setting is off" #21494
Assignees
Labels
area-qa
Relating to QA work (Quality Assurance)
flaky tests
release-12.6.0
Issue or pull request that will be included in release 12.6.0
Sev2-normal
Normal severity; minor loss of service or inconvenience.
team-extension-platform
Comments
metamaskbot
added
the
INVALID-ISSUE-TEMPLATE
chloeYue
added
flaky tests
and removed
INVALID-ISSUE-TEMPLATE
9 tasks
7 tasks
seaona
added
Sev2-normal
github-merge-queue bot
pushed a commit
that referenced
this issue
Oct 2, 2024
…me from 4byte when the setting is off` (#27560) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** This test is failing as it's trying to look for the `Deposit initiated` element in the test dapp and it doesn't appear in time.  We shouldn't care if the test dapp sets the value to Deposit initiated into its div element, as long as the popup is open (which it does). This removes any potential race condition on the test dapp side There are several things to fix/improve around the 2 specs for 4byte, so I took the opportunity to fix those too. [](https://codespaces.new/MetaMask/metamask-extension/pull/27560?quickstart=1) ## **Related issues** Fixes: #21494 ## **Manual testing steps** 1. Check ci 2. Run test locally ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
](https://codespaces.new/MetaMask/metamask-extension/pull/27560?quickstart=1){kind=link}
metamaskbot
added
the
release-12.6.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Failed build: https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/100024/workflows/433aa9de-f5b8-495d-abbc-80034c4db6e3/jobs/3723710
The text was updated successfully, but these errors were encountered: