Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: getNativeCurrency makes Arbitrum, Optimism show incorrect logo #20934

Closed
darkwing opened this issue Sep 18, 2023 · 0 comments · Fixed by #21016
Closed

[Bug]: getNativeCurrency makes Arbitrum, Optimism show incorrect logo #20934

darkwing opened this issue Sep 18, 2023 · 0 comments · Fixed by #21016
Labels
release-11.3.0 Issue or pull request that will be included in release 11.3.0 Sev3-low Low severity; minimal to no impact upon users team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead type-bug

Comments

@darkwing
Copy link
Contributor

darkwing commented Sep 18, 2023 •
edited
Loading

Describe the bug

When on Arbitrum or Optimism, the getNativeCurrency function returns ETH, which makes the getNativeCurrencyImage function return the ETH logo instead of proper logo. This can be seen on the "Switched network" popover:

268180793-f8cc9af1-bcc0-4a7a-97ff-c80193c1bd77

We should ensure the correct logo is displayed on each network

Steps to reproduce

  1. Add Optimism network from Uniswap (by switching networks on Uniswap)
  2. Allow MetaMask to add Optimism
  3. When the "You switched..." popover displays, it will say ETH is the native currency (wrong) and the ETH logo instead of Optimism logo (wrong)

Error messages or log output

No response

Version

11.0

Build type

None

Browser

Chrome

Operating system

MacOS

Hardware wallet

No response

Additional context

No response
@darkwing darkwing mentioned this issue Sep 18, 2023
Merged
8 tasks
@anaamolnar anaamolnar added team-extension-client team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead Sev3-low Low severity; minimal to no impact upon users labels Sep 18, 2023
@darkwing darkwing changed the title [Bug]: getNativeCurrency returns "ETH" for Arbitrum, Optimism chains [Bug]: getNativeCurrency makes Arbitrum, Optimism show incorrect logo Sep 21, 2023
darkwing added a commit that referenced this issue Sep 22, 2023
@darkwing
Fix #20934 - Show network icon in New Network popover
343633d
@darkwing darkwing mentioned this issue Sep 22, 2023
Merged
14 tasks
HowardBraham added a commit that referenced this issue Sep 27, 2023
@darkwing @HowardBraham
Fix #20934 - Show network icon in New Network popover (#21016)
d633b97 
Fixes #20934

This PR ensures the correct network icon displays when switching to a
new network like Optimism and Arbitrum. While ETH may be the native
currency of each of those networks, the chip image should represent the
network.

---------

Co-authored-by: Howard Braham <[email protected]>
@metamaskbot metamaskbot added the release-11.3.0 Issue or pull request that will be included in release 11.3.0 label Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
release-11.3.0 Issue or pull request that will be included in release 11.3.0 Sev3-low Low severity; minimal to no impact upon users team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead type-bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #20934 - Show network icon in New Network popover MetaMask/metamask-extension
4 participants
@darkwing @gauthierpetetin @metamaskbot @anaamolnar