Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide a way to fill empty account #19371

Closed
kevinghim opened this issue Jun 1, 2023 · 1 comment
Closed

Provide a way to fill empty account #19371

kevinghim opened this issue Jun 1, 2023 · 1 comment
Assignees
@darkwing
Labels
team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead

Comments

@kevinghim
Copy link
Contributor

kevinghim commented Jun 1, 2023 •
edited
Loading

Background

Since we've moved the key action buttons such as buy, swap, send, bridge and consolidated them within the global actions, new users might not have adequate direction on how to fill their empty accounts. For this, we want to create a recommendation displayed through new "cards" to buy crypto or receive tokens and NFTs from other accounts.

Requirements

User story

As a new user, I want to get suggestions on how to fill my empty account in order to

  • buy tokens through the "buy" feature on MetaMask portfolio
  • receive tokens and NFTs from another user or account through a QR code

Other details:

  • applies to new wallet with zero account balance
  • this should apply to all new account, not just new wallets
  • new "receive" modal will need to be created
  • text on top of the background

Acceptance criteria

Tokens tab

  • Given that a new wallet has been created and an account is empty of assets
  • When the user opens the wallet's account list screen on the tokens tab
  • Then display a card to buy crypto with cash
  • And display a card to receive tokens through a QR code
  • And when the user buys or receives the token, display new asset with change in total balance
  • And if one card is clicked and action performed, display only remaining card

NFTs tab

  • Given that a new wallet has been created and an account is empty of assets
  • When the user opens the wallet's account list screen on the NFTs tab
  • Then display a card to receive NFTs through a QR code
  • Then card redirects to the same modal with the account details to receive
  • And when receives the NFT, display new NFT on the NFT tab
  • And if one card is clicked and action performed, display only remaining card

Designs

Figma
@kevinghim kevinghim added team-extension-client team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead labels Jun 1, 2023
@kevinghim
Copy link
Contributor Author

Hey team! Please add your planning poker estimate with Zenhub @darkwing @NidhiKJha @vthomas13

darkwing added a commit that referenced this issue Sep 26, 2023
@darkwing
Fix #19371 - Provide conversion buttons for empty accounts
61a38ef
@darkwing darkwing mentioned this issue Sep 26, 2023
Merged
14 tasks
darkwing added a commit that referenced this issue Sep 28, 2023
@darkwing
Fix #19371 - Provide conversion buttons for empty accounts
74a12e8
k-g-j pushed a commit that referenced this issue Nov 1, 2023
@darkwing @k-g-j
Fix #19371 - Provide conversion buttons for empty accounts (#21049)
3767405 
## **Description**
Provides conversion buttons to buy, receive, and learn more about NFTs
when an account is empty.

## **Manual testing steps**
- Start with a MetaMask account with assets in it on Mainnet
- *Don't* see the Buy/Receive blocks
- Create a new account with no assets
- *See* the Buy/Receive blocks
- Switch to a network that we don't support buying on (localhost)
- See *only* the "Receive" block
- Switch to NFTs tab
- See the NFTs block if you have no NFTS
- *Don't* see the NFTs block if you *do* have NFTs

## **Screenshots/Recordings**

### Token List
<img width="799" alt="SCR-20230928-qwwf"
src="https://github.com/MetaMask/metamask-extension/assets/46655/ac72c151-ea8f-479d-a86a-e57d51164ccb">

### NFTs
<img width="815" alt="SCR-20230928-qxau"
src="https://github.com/MetaMask/metamask-extension/assets/46655/910a8d69-3ff5-47ae-9b0a-47b9f10739e1">

## **Related issues**

_Fixes #19371

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've clearly explained:
  - [ ] What problem this PR is solving.
  - [ ] How this problem was solved.
  - [ ] How reviewers can test my changes.
- [ ] I’ve indicated what issue this PR is linked to: Fixes #???
- [ ] I’ve included tests if applicable.
- [ ] I’ve documented any added code.
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
- [ ] I’ve properly set the pull request status:
  - [ ] In case it's not yet "ready for review", I've set it to "draft".
- [ ] In case it's "ready for review", I've changed it from "draft" to
"non-draft".

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@darkwing darkwing

Labels
team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@darkwing @kevinghim @gauthierpetetin