[Bug]: [MV3] Loading a detected phishing page for the first time does not show the phishing page warning

[digiwand]

@seaona observed refreshing the extension from chrome://extensions and then opening a URL detected as a phishing page will not show the phishing warning page.

Looking into this, it appears that the blocklist may not finish loading when the user first lands on a detected phishing page.

Observe breakpoint hit when list has not finished loading (eth-phishing-detect/src/detector):

Observe breakpoint when list is loaded.

Related Repos:

• https://github.com/MetaMask/eth-phishing-detect
• https://github.com/MetaMask/controllers

For some reason, I am only able to repro this issue on MV3 and not MV2.

[segun]

I've been testing this using this branch #15913 and I can't replicate the issue. I always get the phising screen after a refresh.

@seaona can you please check to see if this branch fixes the issue?

[seaona]

I still can reproduce @digiwand 's behaviour mentioned above on the branch you pointed out @segun. The issue is that the phishing list does not load completely.

Steps to repro:

1. Load MV3 MM
2. Add a breakpoint on /detector.js file on line 182 return list.some...
3. Open a phishing page i.e. solascan.name
4. See list of blocked sites is smaller than expected

Some extra information, highlighted by @digiwand: we combine the 2 lists https://static.metafi.codefi.network/api/v1/lists/eth_phishing_detect_config.json and https://static.metafi.codefi.network/api/v1/lists/phishfort_hotlist.json of results.

I noticed that for every pause event from the debugger , we are getting different elements from the list:

• 1266 corresponds to the whitelist array from phishingdetectconfig
• 24379 corresponds to the blacklist array from phishingdetectconfig
• 9583 corresponds to phishfortlist - there are 12179 in total, but here in the video not all of them were loaded, which is problematic

2022-11-22.15-14-41.mp4

[segun]

@seaona Thanks. I'm now able to reproduce the bug and have a fix.