Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all signature requests screens to use the new origin pill and header component #15705

Closed
bschorchit opened this issue Aug 25, 2022 · 1 comment · Fixed by #15776
Closed
Assignees
Labels
area-transactions team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead type-enhancement

Comments

@bschorchit
Copy link

bschorchit commented Aug 25, 2022

Resources

Figma Design file

Acceptance Criteria

  1. When signature requests are displayed, they now show the new origin pill component that was updated on Updated origin pill component to match the new design #15603 and the new header component created on Header component for transaction confirmation screens #15614;
  2. The balance information on the header should display the native asset balance (same as for NFT allowances).
  3. Add main title Signature Request as in design on all confirmations
  4. Remove existing components that contains "Signature Request", account, balance, current network or origin url as those infos are now presented in the new components.
  5. For the three SignTypedData signatures, we should also remove the following icon (screenshot below)
    Untitled

Steps to Reproduce

  1. Open the test dapp https://metamask.github.io/test-dapp/
  2. Under the Eth Sign section, click on "Sign"
  3. Under the Personal Sign section, click on "Sign"
  4. Under the Sign Typed Data section, click on "Sign"
  5. Under the Sign Typed Data V3 section, click on "Sign"
  6. Under the Sign Typed Data V4 section, click on "Sign"
@bschorchit bschorchit added type-enhancement area-transactions team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead labels Aug 25, 2022
@amerkadicE amerkadicE self-assigned this Sep 6, 2022
@bschorchit
Copy link
Author

Related to #13703

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-transactions team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead type-enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants