Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow dapps to signTypedData for non-selected networks #10251

Open
danfinlay opened this issue Jan 22, 2021 · 3 comments
Open

Allow dapps to signTypedData for non-selected networks #10251

danfinlay opened this issue Jan 22, 2021 · 3 comments

Comments

@danfinlay
Copy link
Contributor

@jamesyoung requests the ability to use signTypedData for messages on non-selected networks.

This could be an easier lift than adding true multi-network support, since no data source is needed.

There is a danger that a user who believes they are on a low-stakes/test network is then presented with a higher-stakes confirmation.

One way to mitigate that danger would be to make this dapp ability a permission using EIP 2255 permissions, like Permission to sign messages for the X network.

We would then also indicate the intended network on the signature screen.

Needs UI design and API design.

@danfinlay danfinlay added the needs-design Needs design support. label Jan 22, 2021
@danjm danjm added the area-api label Sep 24, 2021
@kevinghim kevinghim added team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead area-signTypedData labels Jun 9, 2022
@danfinlay
Copy link
Contributor Author

As we build towards enabling connecting to multiple networks at once, it seems inevitable that we will have this feature in some form or another, so answering how we would feel comfortable enabling it safely could help answer questions about safe multi chain connections.

@danfinlay
Copy link
Contributor Author

I personally would love if we could get the confirmations so obviously readable that a user would trivially tell the involved chain/asset, so enabling this could be safe.

@bschorchit
Copy link

Labeling this team-DevRel instead of team-transactions, but also flagging this #15705 as a blocker (PR is waiting for reviews to get merged) so all requests have a component to display the relevant network info (which is not the case currently).

@bschorchit bschorchit added team-devrel and removed needs-design Needs design support. team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead labels Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants