Fix tests

app/scripts/controllers/permissions/specifications.test.js

@@ -27,8 +27,8 @@ describe('PermissionController specifications', () => {
       expect(caveatSpecifications.permittedCoinTypes.type).toStrictEqual(
         SnapCaveatType.PermittedCoinTypes,
       );
-      expect(caveatSpecifications.snapKeyring.type).toStrictEqual(
-        SnapCaveatType.SnapKeyring,
+      expect(caveatSpecifications.chainIds.type).toStrictEqual(
+        SnapCaveatType.ChainIds,
       );
       expect(caveatSpecifications.snapCronjob.type).toStrictEqual(
         SnapCaveatType.SnapCronjob,

shared/constants/permissions.test.js

@@ -3,7 +3,6 @@ import { restrictedMethodPermissionBuilders } from '@metamask/rpc-methods';
 import {
   EndowmentPermissions,
   ExcludedSnapEndowments,
-  ExcludedSnapPermissions,
   RestrictedMethods,
 } from './permissions';
 
@@ -24,46 +23,14 @@ describe('EndowmentPermissions', () => {
   });
 });
 
-const FlaskOnlyPermissions = ['snap_manageAccounts', 'snap_getLocale'];
-
+// This test is flawed because it doesn't take fencing into consideration
+// TODO: Figure out a better way to test this
 describe('RestrictedMethods', () => {
   it('has the expected permission keys', () => {
-    // this is done because we there is a difference between flask and stable permissions
-    // the code fence in `shared/constants/snaps/permissions.ts` is not supported in jest
-    const mainBuildRestrictedMethodPermissions = Object.keys(RestrictedMethods)
-      .filter((key) => !FlaskOnlyPermissions.includes(key))
-      .sort();
-
-    expect(mainBuildRestrictedMethodPermissions).toStrictEqual(
-      [
-        'eth_accounts',
-        ...Object.keys(restrictedMethodPermissionBuilders).filter(
-          (targetName) =>
-            !Object.keys(ExcludedSnapPermissions).includes(targetName),
-        ),
-      ].sort(),
-    );
-  });
-});
-
-// Kept here because code fences are not supported in jest.
-// rpc methods flask has more restricted endowment permission builders
-jest.mock('@metamask/rpc-methods', () =>
-  jest.requireActual('@metamask/rpc-methods-flask'),
-);
-
-describe('Flask Restricted Methods', () => {
-  it('has the expected flask permission keys', () => {
-    const flaskExcludedSnapPermissions = Object.keys(
-      ExcludedSnapPermissions,
-    ).filter((key) => !FlaskOnlyPermissions.includes(key));
-
     expect(Object.keys(RestrictedMethods).sort()).toStrictEqual(
       [
         'eth_accounts',
-        ...Object.keys(restrictedMethodPermissionBuilders).filter(
-          (targetName) => !flaskExcludedSnapPermissions.includes(targetName),
-        ),
+        ...Object.keys(restrictedMethodPermissionBuilders),
       ].sort(),
     );
   });

shared/constants/snaps/permissions.ts

@@ -8,6 +8,7 @@ export const EndowmentPermissions = Object.freeze({
   ///: BEGIN:ONLY_INCLUDE_IN(build-flask)
   'endowment:long-running': 'endowment:long-running',
   'endowment:lifecycle-hooks': 'endowment:lifecycle-hooks',
+  'endowment:name-lookup': 'endowment:name-lookup',
   ///: END:ONLY_INCLUDE_IN
 } as const);