-
Notifications
You must be signed in to change notification settings - Fork 5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add TypeScript migration dashboard (#13820)
As we convert parts of the codebase to TypeScript, we will want a way to track progress. This commit adds a dashboard which displays all of the files that we wish to convert to TypeScript and which files we've already converted. The list of all possible files to convert is predetermined by walking the dependency graph of each entrypoint the build system uses to compile the extension (the files that the entrypoint imports, the files that the imports import, etc). The list should not need to be regenerated, but you can do it by running: yarn ts-migration:enumerate The dashboard is implemented as a separate React app. The CircleCI configuration has been updated so that when a new commit is pushed, the React app is built and stored in the CircleCI artifacts. When a PR is merged, the built files will be pushed to a separate repo whose sole purpose is to serve the dashboard via GitHub Pages (this is the same way that the Storybook works). All of the app code and script to build the app are self-contained under `development/ts-migration-dashboard`. To build this app yourself, you can run: yarn ts-migration:dashboard:build or if you want to build automatically as you change files, run: yarn ts-migration:dashboard:watch Then open the following file in your browser (there is no server component): development/ts-migration-dashboard/build/index.html Finally, although you shouldn't have to do this, to manually deploy the dashboard once built, you can run: git remote add ts-migration-dashboard [email protected]:MetaMask/metamask-extension-ts-migration-dashboard.git yarn ts-migration:dashboard:deploy
- Loading branch information
Showing
29 changed files
with
5,632 additions
and
1,616 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -65,6 +65,9 @@ workflows: | |
- prep-build-storybook: | ||
requires: | ||
- test-storybook | ||
- prep-build-ts-migration-dashboard: | ||
requires: | ||
- prep-deps | ||
- test-lint: | ||
requires: | ||
- prep-deps | ||
|
@@ -146,6 +149,7 @@ workflows: | |
- prep-build-beta | ||
- prep-build-flask | ||
- prep-build-storybook | ||
- prep-build-ts-migration-dashboard | ||
- prep-build-test-mv3 | ||
- benchmark | ||
- stats-module-load-init | ||
|
@@ -165,6 +169,12 @@ workflows: | |
only: develop | ||
requires: | ||
- prep-build-storybook | ||
- job-publish-ts-migration-dashboard: | ||
filters: | ||
branches: | ||
only: develop | ||
requires: | ||
- prep-build-ts-migration-dashboard | ||
|
||
jobs: | ||
create_release_pull_request: | ||
|
@@ -369,6 +379,20 @@ jobs: | |
paths: | ||
- storybook-build | ||
|
||
prep-build-ts-migration-dashboard: | ||
executor: node-browsers | ||
steps: | ||
- checkout | ||
- attach_workspace: | ||
at: . | ||
- run: | ||
name: Build TypeScript migration dashboard | ||
command: yarn ts-migration:dashboard:build | ||
- persist_to_workspace: | ||
root: . | ||
paths: | ||
- development/ts-migration-dashboard/build | ||
|
||
test-storybook: | ||
executor: node-browsers | ||
steps: | ||
|
@@ -686,6 +710,9 @@ jobs: | |
- store_artifacts: | ||
path: storybook-build | ||
destination: storybook | ||
- store_artifacts: | ||
path: development/ts-migration-dashboard/build | ||
destination: ts-migration-dashboard | ||
- run: | ||
name: build:announce | ||
command: ./development/metamaskbot-build-announce.js | ||
|
@@ -722,6 +749,21 @@ jobs: | |
git remote add storybook [email protected]:MetaMask/metamask-storybook.git | ||
yarn storybook:deploy | ||
job-publish-ts-migration-dashboard: | ||
executor: node-browsers | ||
steps: | ||
- add_ssh_keys: | ||
fingerprints: | ||
- "3d:49:29:f4:b2:e8:ea:af:d1:32:eb:2a:fc:15:85:d8" | ||
- checkout | ||
- attach_workspace: | ||
at: . | ||
- run: | ||
name: ts-migration-dashboard:deploy | ||
command: | | ||
git remote add ts-migration-dashboard [email protected]:MetaMask/metamask-extension-ts-migration-dashboard.git | ||
yarn ts-migration:dashboard:deploy | ||
test-unit: | ||
executor: node-browsers | ||
steps: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.