-
Notifications
You must be signed in to change notification settings - Fork 5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
## **Description** Initial UI for a multi rpc editor in the network form. https://github.com/MetaMask/metamask-extension/assets/3500406/1b38f697-56e6-4594-8c74-6fd341c01796 [](https://codespaces.new/MetaMask/metamask-extension/pull/25219?quickstart=1) ## **Related issues** ## **Manual testing steps** - build with yarn; ENABLE_NETWORK_UI_REDESIGN=1 yarn start - Settings -> networks - Should see multi rpc dropdown on ethereum network ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
- Loading branch information
](https://codespaces.new/MetaMask/metamask-extension/pull/25219?quickstart=1){kind=link}
Showing
4 changed files
with
200 additions
and
11 deletions.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
144 changes: 144 additions & 0 deletions
144
ui/pages/settings/networks-tab/networks-form/rpc-url-editor.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,144 @@ | ||
| import React, { useRef, useState } from 'react'; | ||
| import classnames from 'classnames'; | ||
| import { | ||
| Box, | ||
| ButtonIcon, | ||
| ButtonIconSize, | ||
| Icon, | ||
| IconName, | ||
| IconSize, | ||
| Popover, | ||
| PopoverPosition, | ||
| Text, | ||
| } from '../../../../components/component-library'; | ||
| import { | ||
| AlignItems, | ||
| BackgroundColor, | ||
| BorderColor, | ||
| BorderRadius, | ||
| Display, | ||
| IconColor, | ||
| JustifyContent, | ||
| TextColor, | ||
| TextVariant, | ||
| } from '../../../../helpers/constants/design-system'; | ||
| import { useI18nContext } from '../../../../hooks/useI18nContext'; | ||
|
|
||
| export const RpcUrlEditor = ({ currentRpcUrl }: { currentRpcUrl: string }) => { | ||
| // TODO: real endpoints | ||
| const dummyRpcUrls = [ | ||
| currentRpcUrl, | ||
| 'https://dummy.mainnet.public.blastapi.io', | ||
| 'https://dummy.io/v3/blockchain/node/dummy', | ||
| ]; | ||
|
|
||
| const t = useI18nContext(); | ||
| const rpcDropdown = useRef(null); | ||
| const [isOpen, setIsOpen] = useState(false); | ||
| const [currentRpcEndpoint, setCurrentRpcEndpoint] = useState(currentRpcUrl); | ||
|
|
||
| return ( | ||
| <> | ||
| <Text | ||
| className="networks-tab__rpc-header" | ||
| marginTop={1} | ||
| marginBottom={1} | ||
| variant={TextVariant.bodySmBold} | ||
| > | ||
| {t('defaultRpcUrl')} | ||
| </Text> | ||
| <Box | ||
| onClick={() => setIsOpen(!isOpen)} | ||
| className="networks-tab__rpc-dropdown" | ||
| display={Display.Flex} | ||
| justifyContent={JustifyContent.spaceBetween} | ||
| borderRadius={BorderRadius.MD} | ||
| borderColor={BorderColor.borderDefault} | ||
| borderWidth={1} | ||
| padding={2} | ||
| ref={rpcDropdown} | ||
| > | ||
| <Text variant={TextVariant.bodySm}>{currentRpcEndpoint}</Text> | ||
| <ButtonIcon | ||
| iconName={isOpen ? IconName.ArrowUp : IconName.ArrowDown} | ||
| ariaLabel={t('defaultRpcUrl')} | ||
| size={ButtonIconSize.Sm} | ||
| /> | ||
| </Box> | ||
| <Popover | ||
| paddingTop={2} | ||
| paddingBottom={2} | ||
| paddingLeft={0} | ||
| paddingRight={0} | ||
| className="networks-tab__rpc-popover" | ||
| referenceElement={rpcDropdown.current} | ||
| position={PopoverPosition.Bottom} | ||
| isOpen={isOpen} | ||
| > | ||
| {dummyRpcUrls.map((rpcEndpoint) => ( | ||
| <Box | ||
| padding={4} | ||
| display={Display.Flex} | ||
| justifyContent={JustifyContent.spaceBetween} | ||
| key={rpcEndpoint} | ||
| onClick={() => setCurrentRpcEndpoint(rpcEndpoint)} | ||
| className={classnames('networks-tab__rpc-item', { | ||
| 'networks-tab__rpc-item--selected': | ||
| rpcEndpoint === currentRpcEndpoint, | ||
| })} | ||
| > | ||
| {rpcEndpoint === currentRpcEndpoint && ( | ||
| <Box | ||
| className="networks-tab__rpc-selected-pill" | ||
| borderRadius={BorderRadius.pill} | ||
| backgroundColor={BackgroundColor.primaryDefault} | ||
| /> | ||
| )} | ||
| <Text | ||
| as="button" | ||
| color={TextColor.textDefault} | ||
| variant={TextVariant.bodySmMedium} | ||
| backgroundColor={BackgroundColor.transparent} | ||
| > | ||
| {rpcEndpoint} | ||
| </Text> | ||
| <ButtonIcon | ||
| marginLeft={5} | ||
| ariaLabel={t('delete')} | ||
| size={ButtonIconSize.Sm} | ||
| iconName={IconName.Trash} | ||
| color={IconColor.errorDefault} | ||
| // eslint-disable-next-line no-alert | ||
| onClick={() => alert('TODO: delete confirmation modal')} | ||
| /> | ||
| </Box> | ||
| ))} | ||
| <Box | ||
| // eslint-disable-next-line no-alert | ||
| onClick={() => alert('TODO: add RPC modal')} | ||
| padding={4} | ||
| display={Display.Flex} | ||
| alignItems={AlignItems.center} | ||
| className="networks-tab__rpc-item" | ||
| > | ||
| <Icon | ||
| color={IconColor.primaryDefault} | ||
| name={IconName.Add} | ||
| size={IconSize.Sm} | ||
| marginRight={2} | ||
| /> | ||
| <Text | ||
| as="button" | ||
| backgroundColor={BackgroundColor.transparent} | ||
| color={TextColor.primaryDefault} | ||
| variant={TextVariant.bodySmMedium} | ||
| > | ||
| {t('addRpcUrl')} | ||
| </Text> | ||
| </Box> | ||
| </Popover> | ||
| </> | ||
| ); | ||
| }; | ||
|
|
||
| export default RpcUrlEditor; |