fix: catch err on parse abi

MetaMask · Jun 27, 2024 · 88f1388 · 88f1388
1 parent 3c1c3b6
commit 88f1388
Showing 1 changed file with 12 additions and 9 deletions.
diff --git a/app/scripts/metamask-controller.js b/app/scripts/metamask-controller.js
@@ -6381,7 +6381,6 @@ export default class MetamaskController extends EventEmitter {
           txReceiptLog.topics[0] === TRANSFER_SINFLE_LOG_TOPIC_HASH;
         const isERC721NftTransfer =
           txReceiptLog.topics &&
-          txReceiptLog.topics.length === 2 && // Added this check because TOKEN_TRANSFER_LOG_TOPIC_HASH is the same for ERC20 and ERC721
           txReceiptLog.topics[0] === TOKEN_TRANSFER_LOG_TOPIC_HASH;
         let isTransferToSelectedAddress;
 
@@ -6419,14 +6418,18 @@ export default class MetamaskController extends EventEmitter {
             } else {
               iface = new Interface(abiERC721);
             }
-            const parsedLog = iface.parseLog({
-              data: singleLog.data,
-              topics: singleLog.topics,
-            });
-            allNftParsedLog.push({
-              contract: singleLog.address,
-              ...parsedLog,
-            });
+            try {
+              const parsedLog = iface.parseLog({
+                data: singleLog.data,
+                topics: singleLog.topics,
+              });
+              allNftParsedLog.push({
+                contract: singleLog.address,
+                ...parsedLog,
+              });
+            } catch (err) {
+              // ignore
+            }
           }
         });
         // Filter known nfts and new Nfts