Add action for revoking dynamic permissions

MetaMask · Jul 5, 2023 · 88a96a2 · 88a96a2
1 parent dc9c3e6
commit 88a96a2
Show file tree

Hide file tree

Showing 6 changed files with 41 additions and 16 deletions.
diff --git a/app/_locales/en/messages.json b/app/_locales/en/messages.json
diff --git a/app/scripts/metamask-controller.js b/app/scripts/metamask-controller.js
@@ -1800,6 +1800,10 @@ export default class MetamaskController extends EventEmitter {
     this.notificationController.markRead(ids);
   }
 
+  revokeDynamicSnapPermissions(permissions) {
+    // TODO
+  }
+
   ///: END:ONLY_INCLUDE_IN
 
   /**

diff --git a/shared/constants/snaps/permissions.ts b/shared/constants/snaps/permissions.ts
@@ -29,3 +29,5 @@ export const ExcludedSnapEndowments = Object.freeze({
     'endowment:long-running is deprecated. For more information please see https://github.com/MetaMask/snaps-monorepo/issues/945.',
   ///: END:ONLY_INCLUDE_IN
 });
+
+export const DynamicSnapPermissions = Object.freeze(['eth_accounts']);
diff --git a/ui/components/app/permission-cell/permission-cell-options.js b/ui/components/app/permission-cell/permission-cell-options.js
@@ -1,5 +1,6 @@
 import React, { useState, useRef } from 'react';
 import PropTypes from 'prop-types';
+import { useDispatch } from 'react-redux';
 import Box from '../../ui/box';
 import { useI18nContext } from '../../../hooks/useI18nContext';
 import { IconName, ButtonIcon, Text } from '../../component-library';
@@ -9,13 +10,18 @@ import {
   TextVariant,
 } from '../../../helpers/constants/design-system';
 import Popover from '../../ui/popover/popover.component';
+import { DynamicSnapPermissions } from '../../../../shared/constants/snaps/permissions';
+import { revokeDynamicSnapPermissions } from '../../../store/actions';
 
 export const PermissionCellOptions = ({ permissionName, description }) => {
   const t = useI18nContext();
+  const dispatch = useDispatch();
   const ref = useRef(false);
   const [showOptions, setShowOptions] = useState(false);
   const [showDetails, setShowDetails] = useState(false);
 
+  const isRevokable = DynamicSnapPermissions.includes(permissionName);
+
   const handleOpen = () => {
     setShowOptions(true);
   };
@@ -36,7 +42,7 @@ export const PermissionCellOptions = ({ permissionName, description }) => {
 
   const handleRevokePermission = () => {
     setShowOptions(false);
-    // TODO
+    dispatch(revokeDynamicSnapPermissions([permissionName]));
   };
 
   return (
@@ -58,17 +64,19 @@ export const PermissionCellOptions = ({ permissionName, description }) => {
               {t('details')}
             </Text>
           </MenuItem>
-          <MenuItem onClick={handleRevokePermission}>
-            <Text
-              variant={TextVariant.bodySm}
-              color={TextColor.errorDefault}
-              style={{
-                whiteSpace: 'nowrap',
-              }}
-            >
-              {t('revokePermission')}
-            </Text>
-          </MenuItem>
+          {isRevokable && (
+            <MenuItem onClick={handleRevokePermission}>
+              <Text
+                variant={TextVariant.bodySm}
+                color={TextColor.errorDefault}
+                style={{
+                  whiteSpace: 'nowrap',
+                }}
+              >
+                {t('revokePermission')}
+              </Text>
+            </MenuItem>
+          )}
         </Menu>
       )}
       {showDetails && (

diff --git a/ui/pages/settings/snaps/view-snap/view-snap.js b/ui/pages/settings/snaps/view-snap/view-snap.js
@@ -151,7 +151,7 @@ function ViewSnap() {
         <SnapPermissionsList
           permissions={permissions ?? {}}
           targetSubjectMetadata={targetSubjectMetadata}
-          showOptions={true}
+          showOptions
         />
       </Box>
       <Box className="view-snap__connected-sites" marginTop={12}>

diff --git a/ui/store/actions.ts b/ui/store/actions.ts
@@ -1240,6 +1240,17 @@ export function markNotificationsAsRead(
   };
 }
 
+export function revokeDynamicSnapPermissions(
+  permissions: string[],
+): ThunkAction<void, MetaMaskReduxState, unknown, AnyAction> {
+  return async (dispatch: MetaMaskReduxDispatch) => {
+    await submitRequestToBackground('revokeDynamicSnapPermissions', [
+      permissions,
+    ]);
+    await forceUpdateMetamaskState(dispatch);
+  };
+}
+
 ///: END:ONLY_INCLUDE_IN
 ///: BEGIN:ONLY_INCLUDE_IN(desktop)
-Original file line number
+Diff line change
@@ Expand Up @@
         this.notificationController.markRead(ids);
       }
+      revokeDynamicSnapPermissions(permissions) {
+        // TODO
+      }
       ///: END:ONLY_INCLUDE_IN
       /**
@@ Expand Down @@