Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore: Fully remove
eth_sign
(#24756)
## Explanation Months ago, because of phishing risk, we disabled the `eth_sign` API method by default (users could manually enable it with a preference toggle). Now because of additional risk associated with [potentially malicious EIP-3074 invokers](https://ethereum-magicians.org/t/eip-3074-is-unsafe-unnecessary-puts-user-funds-at-risk-while-fragmenting-ux-liquidity-and-the-wallet-stack/19662) we are fully removing support for this method. This PR introduces the changes to `@metamask/signature-controller` and `@metamask/preferences-controller` from MetaMask/core#4319 which remove `eth_sign` related infrastructure. Additionally it removes all instances of `eth_sign` components and references from the extension codebase. ## References * Fixes MetaMask/MetaMask-planning#2371 ## **Manual testing steps** 1. Go to the [e2e test dapp](https://metamask.github.io/test-dapp/) 2. Connect the wallet 3. Scroll down to the `Eth Sign` card (https://metamask.github.io/test-dapp/#ethSign) 4. Click `Sign` 5. You should see `Error: The method "eth_sign" does not exist / is not available.` ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
- Loading branch information